From cc033373d56ffe59e538772a26f4d7a88cad21cb Mon Sep 17 00:00:00 2001 From: tylurp Date: Thu, 13 Aug 2020 13:12:39 -0700 Subject: [PATCH] update cran comments for resubmission --- .Rbuildignore | 1 + DESCRIPTION | 4 ++-- README.Rmd | 4 ++-- README.md | 60 ++++++++++++++++++++++++------------------------ cran-comments.md | 5 ++++ 5 files changed, 40 insertions(+), 34 deletions(-) diff --git a/.Rbuildignore b/.Rbuildignore index e9d67f2..d5b49fe 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -8,3 +8,4 @@ ^\.github$ ^data-raw$ ^cran-comments\.md$ +^CRAN-RELEASE$ diff --git a/DESCRIPTION b/DESCRIPTION index 6e9472b..939d0ff 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -13,8 +13,8 @@ RoxygenNote: 7.1.1 Imports: shiny, htmltools -URL: https://github.com/tyluRp/hover -BugReports: https://github.com/tyluRp/hover/issues +URL: https://github.com/r4fun/hover +BugReports: https://github.com/r4fun/hover/issues Suggests: testthat Depends: diff --git a/README.Rmd b/README.Rmd index 181e65d..bad9a86 100644 --- a/README.Rmd +++ b/README.Rmd @@ -16,8 +16,8 @@ knitr::opts_chunk$set( # hover -[![R build status](https://github.com/tyluRp/hover/workflows/R-CMD-check/badge.svg)](https://github.com/tyluRp/hover/actions) -[![Codecov test coverage](https://codecov.io/gh/tyluRp/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/tyluRp/hover?branch=master) +[![R build status](https://github.com/r4fun/hover/workflows/R-CMD-check/badge.svg)](https://github.com/r4fun/hover/actions) +[![Codecov test coverage](https://codecov.io/gh/r4fun/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/r4fun/hover?branch=master) The goal of hover is to add animations to `shiny::actionButton`, `shiny::downloadButton`, and `shiny::icon` using [Hover.css](https://github.com/IanLunn/Hover). diff --git a/README.md b/README.md index ceb78ce..19ba6e6 100644 --- a/README.md +++ b/README.md @@ -1,64 +1,64 @@ -# hover +hover +===== [![R build -status](https://github.com/tyluRp/hover/workflows/R-CMD-check/badge.svg)](https://github.com/tyluRp/hover/actions) +status](https://github.com/r4fun/hover/workflows/R-CMD-check/badge.svg)](https://github.com/r4fun/hover/actions) [![Codecov test -coverage](https://codecov.io/gh/tyluRp/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/tyluRp/hover?branch=master) +coverage](https://codecov.io/gh/r4fun/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/r4fun/hover?branch=master) The goal of hover is to add animations to `shiny::actionButton`, `shiny::downloadButton`, and `shiny::icon` using [Hover.css](https://github.com/IanLunn/Hover). -## Installation +Installation +------------ You can install the development version of hover from GitHub with: -``` r -# install.packages("devtools") -devtools::install_github("r4fun/hover") -``` + # install.packages("devtools") + devtools::install_github("r4fun/hover") -## Example +Example +------- Animate a button and icon by providing the animation name: -``` r -library(shiny) -library(hover) + library(shiny) + library(hover) -ui <- fluidPage( - use_hover(), - hover_action_button( - inputId = "btn", - label = "hello hover!", - icon = icon("refresh"), - button_animation = "rotate", - icon_animation = "spin" - ) -) + ui <- fluidPage( + use_hover(), + hover_action_button( + inputId = "btn", + label = "hello hover!", + icon = icon("refresh"), + button_animation = "rotate", + icon_animation = "spin" + ) + ) -server <- function(input, output, session) { - -} + server <- function(input, output, session) { + + } -shinyApp(ui, server) -``` + shinyApp(ui, server) The `hover` package essentially takes the `shiny::actionButton` source code and applies the necessary Hover.css classes to make things move. -## Acknowledgements +Acknowledgements +---------------- This package was built using the following tools: - - [Hover.css](https://github.com/IanLunn/Hover), the underlying CSS - - [shiny](https://github.com/rstudio/shiny), the source code for +- [Hover.css](https://github.com/IanLunn/Hover), the underlying CSS +- [shiny](https://github.com/rstudio/shiny), the source code for `hover_button` Without these, this package wouldn’t have been possible. diff --git a/cran-comments.md b/cran-comments.md index aee4e45..8dccf97 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,3 +1,8 @@ +## Resubmission +This is a resubmission. In this version I have: + +*Resolved broken links. + ## Test environments * local R installation, R 4.0.2 * ubuntu 16.04 (on travis-ci), R 4.0.2