Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release (mac): Magnet links open app but don’t process link #22303

Open
lukemmtt opened this issue Feb 19, 2025 · 6 comments
Open

Pre-release (mac): Magnet links open app but don’t process link #22303

lukemmtt opened this issue Feb 19, 2025 · 6 comments
Labels
OS: macOS Issues specific to macOS

Comments

@lukemmtt
Copy link
Contributor

lukemmtt commented Feb 19, 2025

qBittorrent & operating system versions

qbittorrent: master branch
macOS: 15.3.0

What is the problem?

On mac, in the alpha build and master branch, clicking on a magnet link does not show a prompt or start the download. It opens the app, but nothing more. I observed this in my testing while preparing #22284.

Steps to reproduce

  • Install alpha/master
  • Click on a magnet link, like in safari
  • qbittorrent opens, but does nothing more.

Validation:

  • Install Stable build
  • Click on magnet link in safari
  • qbittorrent opens and begins downloading the magnet linked content
@ShlomobCohen
Copy link

This problem started after these two commits were applied to qtbase:-

qt/qtbase@664c7ff
qt/qtbase@e8e881b

Revert the above commits to test:-

git revert --no-commit 664c7ffb212eb898ed03f7b19c883400fa027b6b
git revert --no-commit e8e881ba35fe7009961cbeb4b89efedc5371d5b5

and recompile qt and the links should work as they should.

Not sure whether the above commits are broken or qBittorrent needs to be modified to handle the new scheme.

Hope this helps

@ShlomobCohen
Copy link

The alpha build of qBittorrent uses qt-6.8.1.
The above mentioned commits are present in qt-6.8.1
#22303

@xavier2k6
Copy link
Member

@lukemmtt @ShlomobCohen macOS is barely supported as previously announced on our main website.

The macOS version is not well supported, because we don't have active macOS developers/contributors. The project is in need of macOS developers. If you are a macOS developer willing to help, just go to our bug tracker for a list of macOS related issues. Or try to fix bugs that you yourself have discovered and annoy you.

There are deprecations that have yet to be handled!

macOS related tickets

@xavier2k6 xavier2k6 added the OS: macOS Issues specific to macOS label Feb 20, 2025
@lukemmtt
Copy link
Contributor Author

@xavier2k6 Thank you for the quick response. I completely understand the challenges with macOS support—in fact, I just finished contributing a macOS-specific fix (#22284, merged yesterday into master) when I discovered this magnet link regression during testing.

I filed this issue to track what appears to be a notable regression in core functionality between stable and master/alpha builds. While I hadn't conducted extensive testing beyond my initial observation, I thought it worth reporting promptly, especially as it wasn't immediately clear if this issue might affect more prominently-supported platforms than macOS.

While @ShlomobCohen's investigation now clarifies that this issue is indeed likely specific to macOS (thanks!), I believe tracking such regressions is valuable for the project regardless of platform. I'm currently tied up with other commitments, but wanted to ensure this was properly documented.

@xavier2k6
Copy link
Member

Adding the relevant QTBUG-124340 report from @ShlomobCohen investigations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: macOS Issues specific to macOS
Projects
None yet
Development

No branches or pull requests

3 participants