From 22defecfdbc263749340bf69df68c5ac185af918 Mon Sep 17 00:00:00 2001 From: Divyansh Khanna Date: Thu, 5 Dec 2024 11:00:45 -0800 Subject: [PATCH 1/4] add 3.13t to CI workflows --- .github/workflows/_build_test_upload.yml | 1 + .github/workflows/nodes_ci.yml | 6 +----- .github/workflows/stateful_dataloader_ci.yml | 6 +----- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/_build_test_upload.yml b/.github/workflows/_build_test_upload.yml index b5df9142b..8d10862c6 100644 --- a/.github/workflows/_build_test_upload.yml +++ b/.github/workflows/_build_test_upload.yml @@ -62,6 +62,7 @@ jobs: - "3.11" - "3.12" - "3.13" + - "3.13t" - pure exclude: - os: windows-latest diff --git a/.github/workflows/nodes_ci.yml b/.github/workflows/nodes_ci.yml index 2a044ea7c..aded3b870 100644 --- a/.github/workflows/nodes_ci.yml +++ b/.github/workflows/nodes_ci.yml @@ -30,11 +30,7 @@ jobs: - "3.11" - "3.12" - "3.13" - exclude: - - os: macos-latest - python-version: "3.13" - - os: windows-latest - python-version: "3.13" + - "3.13t" steps: - name: Get PyTorch Channel shell: bash diff --git a/.github/workflows/stateful_dataloader_ci.yml b/.github/workflows/stateful_dataloader_ci.yml index f0d27a0e3..702fde8b2 100644 --- a/.github/workflows/stateful_dataloader_ci.yml +++ b/.github/workflows/stateful_dataloader_ci.yml @@ -30,11 +30,7 @@ jobs: - "3.11" - "3.12" - "3.13" - exclude: - - os: macos-latest - python-version: "3.13" - - os: windows-latest - python-version: "3.13" + - "3.13t" steps: - name: Get PyTorch Channel shell: bash From b3a820a0b7679aad2cef38889991057d1e803f5b Mon Sep 17 00:00:00 2001 From: Divyansh Khanna Date: Thu, 5 Dec 2024 11:47:49 -0800 Subject: [PATCH 2/4] add move exclusion for macos and windows for 3.13 --- .github/workflows/nodes_ci.yml | 5 +++++ .github/workflows/stateful_dataloader_ci.yml | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/nodes_ci.yml b/.github/workflows/nodes_ci.yml index aded3b870..88b68de81 100644 --- a/.github/workflows/nodes_ci.yml +++ b/.github/workflows/nodes_ci.yml @@ -31,6 +31,11 @@ jobs: - "3.12" - "3.13" - "3.13t" + exclude: + - os: macos-latest + python-version: "3.13" + - os: windows-latest + python-version: "3.13" steps: - name: Get PyTorch Channel shell: bash diff --git a/.github/workflows/stateful_dataloader_ci.yml b/.github/workflows/stateful_dataloader_ci.yml index 702fde8b2..c4fdbc888 100644 --- a/.github/workflows/stateful_dataloader_ci.yml +++ b/.github/workflows/stateful_dataloader_ci.yml @@ -31,6 +31,11 @@ jobs: - "3.12" - "3.13" - "3.13t" + exclude: + - os: macos-latest + python-version: "3.13" + - os: windows-latest + python-version: "3.13" steps: - name: Get PyTorch Channel shell: bash From e47c8556ec7983b8e4b5b14076f241a0aed17803 Mon Sep 17 00:00:00 2001 From: Divyansh Khanna Date: Thu, 5 Dec 2024 12:05:53 -0800 Subject: [PATCH 3/4] quick test on echo GITHUB_OUTPUT --- .github/workflows/nodes_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodes_ci.yml b/.github/workflows/nodes_ci.yml index 88b68de81..833faa479 100644 --- a/.github/workflows/nodes_ci.yml +++ b/.github/workflows/nodes_ci.yml @@ -45,7 +45,7 @@ jobs: else PT_CHANNEL="https://download.pytorch.org/whl/nightly/cpu" fi - echo "value=$PT_CHANNEL" >> $GITHUB_OUTPUT + echo "value=$PT_CHANNEL" >> "$GITHUB_OUTPUT" id: pytorch_channel - name: Setup additional system libraries if: startsWith( matrix.os, 'ubuntu' ) From 7d8c431d72e69435a84c6235790e4c55fa726562 Mon Sep 17 00:00:00 2001 From: Divyansh Khanna Date: Thu, 5 Dec 2024 13:11:42 -0800 Subject: [PATCH 4/4] testing --- .github/workflows/nodes_ci.yml | 9 ++------- .github/workflows/stateful_dataloader_ci.yml | 7 +------ 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/.github/workflows/nodes_ci.yml b/.github/workflows/nodes_ci.yml index 833faa479..9af374538 100644 --- a/.github/workflows/nodes_ci.yml +++ b/.github/workflows/nodes_ci.yml @@ -31,11 +31,6 @@ jobs: - "3.12" - "3.13" - "3.13t" - exclude: - - os: macos-latest - python-version: "3.13" - - os: windows-latest - python-version: "3.13" steps: - name: Get PyTorch Channel shell: bash @@ -45,7 +40,7 @@ jobs: else PT_CHANNEL="https://download.pytorch.org/whl/nightly/cpu" fi - echo "value=$PT_CHANNEL" >> "$GITHUB_OUTPUT" + echo "value=$PT_CHANNEL" >> $GITHUB_OUTPUT id: pytorch_channel - name: Setup additional system libraries if: startsWith( matrix.os, 'ubuntu' ) @@ -73,7 +68,7 @@ jobs: run: | pip3 install -r requirements.txt pip3 install networkx - pip3 install --pre torch --index-url "${{ steps.pytorch_channel.outputs.value }}" + pip3 install --pre torch --index-url ${{ steps.pytorch_channel.outputs.value }} pip3 install cmake ninja echo "/home/runner/.local/bin" >> $GITHUB_PATH - name: Build TorchData diff --git a/.github/workflows/stateful_dataloader_ci.yml b/.github/workflows/stateful_dataloader_ci.yml index c4fdbc888..da9e23e1a 100644 --- a/.github/workflows/stateful_dataloader_ci.yml +++ b/.github/workflows/stateful_dataloader_ci.yml @@ -31,11 +31,6 @@ jobs: - "3.12" - "3.13" - "3.13t" - exclude: - - os: macos-latest - python-version: "3.13" - - os: windows-latest - python-version: "3.13" steps: - name: Get PyTorch Channel shell: bash @@ -73,7 +68,7 @@ jobs: run: | pip3 install -r requirements.txt pip3 install networkx - pip3 install --pre torch --index-url "${{ steps.pytorch_channel.outputs.value }}" + pip3 install --pre torch --index-url ${{ steps.pytorch_channel.outputs.value }} pip3 install cmake ninja echo "/home/runner/.local/bin" >> $GITHUB_PATH - name: Build TorchData