-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: Add search to the PEP index #4083
Comments
Agreed that it would be useful, it's something I often miss. |
Nice idea @nineteendo. |
I spent some time looking into this today, and here's what I've found so far: sphinx search was intentionally disabled in #1934 (comment) , recommending folks use public search engines with site-scoping. I tried reenabling sphinx search, and it's not too bad of a change, but since the general approach sphinx "wants" is to have a theme that extends an existing one (like Largely, it comes from here: peps/pep_sphinx_extensions/pep_processor/html/pep_html_builder.py Lines 9 to 23 in 1fb889b
I'd be happy to continue to poke at this if there's continued interest in having a PEP web search, and don't want to invest the effort if it's not going to pass a review ;) |
Indeed, disabling search was intentional, both to improve performance and as Sphinx's search isn't that great, so readers are better served by using their favourite search engine (there are many discussions about this on Sphinx's side, notably https://github.com/orgs/sphinx-doc/discussions/12419, but the précis is that improving search is costly and will take a not insignificant amount of effort to do right). A |
I currently search like this: https://github.com/search?q=repo%3Apython%2Fpeps+lang%3AreStructuredText&type=code
It would be easier if the was a search box on https://peps.python.org.
The text was updated successfully, but these errors were encountered: