Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension modules - update MSVC for standalone module #1394

Open
zooba opened this issue Sep 11, 2024 · 2 comments
Open

Extension modules - update MSVC for standalone module #1394

zooba opened this issue Sep 11, 2024 · 2 comments
Labels
guide-new content Additions; New content or section needed

Comments

@zooba
Copy link
Member

zooba commented Sep 11, 2024

The page https://devguide.python.org/developer-workflow/extension-modules/#updating-msvc-project-files has recently been updated with fantastic content.

However, it currently only shows how to add a built-in module for Windows, and not a separate extension module.

We should add a second section that adds a new .vcxproj for the new extension module (or more likely copies a recommended existing one), along with the other changes necessary to ensure the new module is correctly built and distributed.

@zooba zooba added the guide-new content Additions; New content or section needed label Sep 11, 2024
@picnixz
Copy link
Contributor

picnixz commented Sep 13, 2024

Oh thank you for this Steve. I indeed see that I only mentioned the pythoncore.vcxproj file, so I'll try to come up with something for a separate extension module. I never used MSVC and the section I wrote about MSVC was mostly a guess hence the confusion on my side.

@zooba
Copy link
Member Author

zooba commented Sep 13, 2024

Yeah, no worries. This is as much a note to myself (or an invitation to anyone else who wants to contribute) as anything else. Certainly not meant as a criticism of your work so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guide-new content Additions; New content or section needed
Projects
None yet
Development

No branches or pull requests

2 participants