Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDBM configure checks are missing context #129388

Open
erlend-aasland opened this issue Jan 28, 2025 · 1 comment
Open

GDBM configure checks are missing context #129388

erlend-aasland opened this issue Jan 28, 2025 · 1 comment
Assignees
@erlend-aasland
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 28, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Many of the *DBM checks are not performed correctly in configure; they're performing the checks without the user-supplied GDBM_* environment variables. On my MacBook, this leads to gdbm-ndbm.h not being recognised, even though Homebrew does ship it.

CPython versions tested on:

3.14, 3.13, 3.12

Operating systems tested on:

No response

Linked PRs
@erlend-aasland erlend-aasland added build The build process and cross-build type-bug An unexpected behavior, bug, or error labels Jan 28, 2025
@erlend-aasland erlend-aasland self-assigned this Jan 28, 2025
@erlend-aasland
Copy link
Contributor Author

Discovered while working on a fix for #115806 (comment).

@bedevere-app bedevere-app bot mentioned this issue Jan 28, 2025
Draft
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jan 28, 2025
@erlend-aasland
pythongh-129388: Use user supplied env vars when checking for gdbm deps
4f13267 
Use GDBM_CFLAGS and GDBM_LIBS for all gdbm related checks.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jan 28, 2025
@erlend-aasland
pythongh-129388: Don't mangle gdbm header dependency detection output
ca7ef81 
Replace AC_CACHE_VAL/AC_CHECK_HEADER with a cleaner variant using
AC_CACHE_CHECK/AC_PREPROC_IFELSE.

The former would produce garbled output when config.cache was reused. It
also required directly manipulating GNU Autoconf cache variables.
@bedevere-app bedevere-app bot mentioned this issue Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erlend-aasland