Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: deprecation of using access_token query param #430

Closed
fsworld009 opened this issue Feb 6, 2020 · 6 comments
Closed

GitHub: deprecation of using access_token query param #430

fsworld009 opened this issue Feb 6, 2020 · 6 comments

Comments

@fsworld009
Copy link

fsworld009 commented Feb 6, 2020 •
edited
Loading

GitHub announced deprecation of using access_token query param to make API requests:

https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/

This package's github backend needs to migrate to use Basic Authentication in order to continue supporting GitHub.
@fsworld009
Copy link
Author

Just saw someone already made a PR for it #428

@fsworld009 fsworld009 reopened this Feb 6, 2020
@ThomasWaldmann ThomasWaldmann mentioned this issue Feb 6, 2020
Open
@asherf asherf mentioned this issue Feb 6, 2020
Merged
@asherf
Copy link
Contributor

asherf commented Feb 6, 2020

Thanks for creating the issue !
IMHO we should keep this issue open until the PR is merged!

@rafaelcapucho
Copy link

Hi, I'm facing the same issue, receiving these emails:

Hi @rafaelcapucho,

On February 9th, 2020 at 22:37 (UTC) your application (OauthGitHubStudentDeveloperPack) used an access token (with the User-Agent python-requests/2.22.0) as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/user

Please use the Authorization HTTP header instead as using the `access_token` query parameter is deprecated and will be removed July 1st, 2020.

Depending on your API usage, we'll be sending you this email reminder once every 3 days.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

Thanks,
The GitHub Team

Thank you

@vsoch
Copy link

vsoch commented Feb 13, 2020

Me as well!

@ryanpetrello ryanpetrello mentioned this issue Feb 18, 2020
Closed
atodorov added a commit to kiwitcms/github-app that referenced this issue Feb 19, 2020
@atodorov
Address GitHub deprecation not yet fixed in social-auth-core v3.2.0
6717211 
Reported in:
python-social-auth/social-core#430

Patch in:
python-social-auth/social-core#428
@atodorov atodorov mentioned this issue Feb 19, 2020
Merged
atodorov added a commit to kiwitcms/github-app that referenced this issue Feb 19, 2020
@atodorov
Address GitHub deprecation not yet fixed in social-auth-core v3.2.0
a990aa8 
Reported in:
python-social-auth/social-core#430

Patch in:
python-social-auth/social-core#428
mateuszmandera added a commit to mateuszmandera/zulip that referenced this issue Mar 1, 2020
@mateuszmandera
auth: Monkey patch a fix for Github deprecation notice spam.
27434c3 
This is a way to monkey-patch a fix for
python-social-auth/social-core#430
Changes from this commit should be reverted once the issue is fixed
upstream.
mateuszmandera added a commit to mateuszmandera/zulip that referenced this issue Mar 1, 2020
@mateuszmandera
auth: Monkey patch a fix for Github deprecation notice spam.
e86ba13 
This is a way to monkey-patch a fix for
python-social-auth/social-core#430
Changes from this commit should be reverted once the issue is fixed
upstream.
timabbott pushed a commit to zulip/zulip that referenced this issue Mar 3, 2020
@mateuszmandera @timabbott
auth: Monkey patch a fix for Github deprecation notice spam.
217431d 
This is a way to monkey-patch a fix for
python-social-auth/social-core#430
Changes from this commit should be reverted once the issue is fixed
upstream.
timabbott pushed a commit to zulip/zulip that referenced this issue Mar 3, 2020
@mateuszmandera @timabbott
auth: Monkey patch a fix for Github deprecation notice spam.
e506dbc 
This is a way to monkey-patch a fix for
python-social-auth/social-core#430
Changes from this commit should be reverted once the issue is fixed
upstream.
arunikayadav42 pushed a commit to arunikayadav42/zulip that referenced this issue Mar 12, 2020
@mateuszmandera @arunikayadav42
auth: Monkey patch a fix for Github deprecation notice spam.
3827df7 
This is a way to monkey-patch a fix for
python-social-auth/social-core#430
Changes from this commit should be reverted once the issue is fixed
upstream.
@mateuszmandera
Copy link
Contributor

mateuszmandera commented Mar 18, 2020 •
edited
Loading

@fsworld009 @omab This can be closed, this was a duplicate of another issue on this, the #428 PR is merged.

@omab
Copy link
Contributor

omab commented Mar 18, 2020

Fixed by #428

@omab omab closed this as completed Mar 18, 2020
stableapple pushed a commit to stableapple/zulip that referenced this issue Mar 27, 2020
@mateuszmandera @stableapple
auth: Monkey patch a fix for Github deprecation notice spam.
76885ee 
This is a way to monkey-patch a fix for
python-social-auth/social-core#430
Changes from this commit should be reverted once the issue is fixed
upstream.
@goneall goneall mentioned this issue Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@omab @rafaelcapucho @vsoch @asherf @fsworld009 @mateuszmandera