Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AoC: Convert commands to hybrid slash commands (ephemeral where reasonable) #97

Open
janine9vn opened this issue Nov 2, 2023 · 5 comments · May be fixed by #101
Open

AoC: Convert commands to hybrid slash commands (ephemeral where reasonable) #97

janine9vn opened this issue Nov 2, 2023 · 5 comments · May be fixed by #101
Assignees
Labels
Area: Advent of code Ready for Implementation Proposed approach/implementation is solid, let's implement this thing

Comments

@janine9vn
Copy link
Collaborator

janine9vn commented Nov 2, 2023

The following commands should be converting to hybrid slash commands:

The following commands should be converted to slash-only and be ephemeral:

  • connect/link
  • disconnect/unlink

The following commands should only be able to be run in advent-of-code-bot-commands, sir-lancebot-playground, or bot-commands. If they are tried to run elsewhere, they should redirect to advent-of-code-bot-commands and let the user know.

  • daystar
  • leaderboard
  • global leaderboard
  • stats
@janine9vn janine9vn added Ready for Implementation Proposed approach/implementation is solid, let's implement this thing Area: Advent of code labels Nov 2, 2023
@n0Oo0Oo0b n0Oo0Oo0b self-assigned this Nov 2, 2023
@Robin5605 Robin5605 changed the title AoC: Convert commands to hybrid slash commands (ephemral where reasonable) AoC: Convert commands to hybrid slash commands (ephemeral where reasonable) Nov 2, 2023
@Robin5605
Copy link
Contributor

@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.

@n0Oo0Oo0b
Copy link

@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.

Sure, how should I split the tasks?

@Robin5605
Copy link
Contributor

@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.

Sure, how should I split the tasks?

@n0Oo0Oo0b I think splitting it up the same way Kat's done it should work. We could make PRs for each of them, so they can be reviewed more effectively. For instance, a PR titled Convert &daystar command into a hybrid command. This way we can get multiple people working on this issue at once as well

@n0Oo0Oo0b n0Oo0Oo0b linked a pull request Nov 8, 2023 that will close this issue
@n0Oo0Oo0b
Copy link

Seems like converting all of them in one go would be pretty straightforward (see #101 (comment)), so I don't think it's necessary to split this issue up anymore.

@Robin5605 Robin5605 self-assigned this Nov 29, 2023
@Robin5605
Copy link
Contributor

@janine9vn just wanted to ask, what's the reasoning behind making only the link/unlink commands fully slash commands, and making the other hybrids?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Advent of code Ready for Implementation Proposed approach/implementation is solid, let's implement this thing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants