added guess the number game #1405
Conversation
Xithrius
added
type: feature
| await ctx.send("Timeout!") | ||
| return | ||
|
|
||
| if not user_guess.content.isdigit(): |
There was a problem hiding this comment.
isdigit would break on some instances as it takes unicode into account.
For example, if you call '²'.isdigit(), it'll return True.
Instead, wrap it in a try.except block where you try to convert it into an integer by calling int(content)
| return | ||
|
|
||
| if not user_guess.content.isdigit(): | ||
| await ctx.send(f"**Invalid guess**, Please guess a number. Try again, You've {tries} left.") |
There was a problem hiding this comment.
This would look better in an Embed IMO.
| return | ||
|
|
||
| if not user_guess.content.isdigit(): | ||
| await ctx.send(f"**Invalid guess**, Please guess a number. Try again, You've {tries} left.") |
There was a problem hiding this comment.
I'm not sure here whether we should just quit on invalid numbers, or otherwise set a counter for the number of invalid tries a user can have, otherwise this could keep on going forever. I think both are fine.
What i'm sure of though, is that we shouldn't let a backdoor that'll keep the command running forever.
| if not user_guess.content.isdigit(): | ||
| await ctx.send(f"**Invalid guess**, Please guess a number. Try again, You've {tries} left.") | ||
|
|
||
| elif int(user_guess.content) == self.active_games[ctx.author.id]: |
There was a problem hiding this comment.
You should make the conversion only once, before anything else, then keep on using the converted number if successfull. The conversion should be done like I indicated in my previous comment.
| else: | ||
| tries = tries - 1 | ||
| if tries == 0: | ||
| await ctx.channel.send( |
There was a problem hiding this comment.
This can go into the while loop's else block, which separates the end game code from the rest & makes it clearer & less indented.
wookie184
added
status: waiting for author
|
@sarzz2 Hey, just checking up. Will you be continuing this PR? Thanks! |
Yes, been a little busy with work lately. Planning to do it by next week. |
Relevant Issues
Closes #1082
Description
Added new cog of guess the number game
Did you: