Normalize wheel filenames #135
Conversation
stefanor
force-pushed
the
normalize-names
branch
from
3e2e542
to
2d86655
Compare
| @@ -101,7 +109,9 @@ def parse_wheel_filename(filename: str) -> WheelFilename: | |||
| wheel_info = _WHEEL_FILENAME_REGEX.match(filename) | |||
| if not wheel_info: | |||
| raise ValueError(f"Not a valid wheel filename: {filename}") | |||
| return WheelFilename(*wheel_info.groups()) | |||
| parsed = wheel_info.groups() | |||
| normalized_name = normalize_distribution_name(parsed[0]) | |||
There was a problem hiding this comment.
Sadly, we don't know for sure if the name inside the wheel will be canonicalized.
For example, zope.interface's wheels contain zope.interface-5.4.0.dist-info (and not zope-interface) thanks, in no small part, to setuptools' behaviour in this area.
There was a problem hiding this comment.
Oh, wait, that's what this is doing. :)
There was a problem hiding this comment.
So, we're going to either need to probe a few names, or search the directory listing.
There was a problem hiding this comment.
I see pip searches the zip for a .dist-info. So I guess we should do that.
There was a problem hiding this comment.
I agree. Let's close this out, since we've established that merely canonicalising the name isn't sufficient.
This is a fairly simple solution to #134, without any refactoring needed to close #97.
There are other places this normalization could be done, but this seems like the logical place to do it. It does mean that you can't get back from a
WheelFilenameobject to the filename on disk, but that doesn't seem very important.Fixes: #134