Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CygwinCCompiler is never used #185

Open
naveen521kk opened this issue Oct 29, 2022 · 2 comments
Open

CygwinCCompiler is never used #185

naveen521kk opened this issue Oct 29, 2022 · 2 comments

Comments

@naveen521kk
Copy link
Contributor

naveen521kk commented Oct 29, 2022

While working on #184 I found that CygwinCCompiler is never used. If it was used it should be failing with TypeError as there's something wrong with get_msvcr (it shouldn't be returning None, https://github.com/pypa/distutils/pull/184/files#r1008651830).

It uses UnixCCompiler instead while compiling on that platform.

$ python -c 'import distutils.ccompiler as a; print(a.new_compiler())'
<distutils.unixccompiler.UnixCCompiler object at 0x6ffffff07c10>

I think the below line should be changed to cygwin instead of unix to use the correct compiler classes. Not sure why it was set to unix though. (and the blame is 22 years old, so no idea e49a115)

('cygwin.*', 'unix'),

@radarhere
Copy link

You may be interested to know that #209 (comment) suggested dropping CygwinCCompiler instead.

@jaraco
Copy link
Member

jaraco commented Jul 15, 2024

What's the status of this issue now that #209 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants