gzip support?

[makc]

I was getting 404 for some file before I did this

    xhr.open(method, url, true)
    if XMLHttpRequest.prototype._restrictedHeaders
        delete XMLHttpRequest.prototype._restrictedHeaders['accept-encoding']
        xhr.setRequestHeader('Accept-Encoding', 'gzip, deflate')

Now I don't get 404, but the data is obviously garbage. Is there easy way to get unzipped content in this case?

[pwnall]

The server must have a weird configuration.

I'd look into zlib, it is built into node.js (at least for 0.10 and 0.12).
https://nodejs.org/docs/v0.10.0/api/zlib.html

This sounds like an useful thing to support out of the box. Sorry I don't have time to work on it right now! We can leave the issue open for when I have time to get to it.

[makc]

yes, server does not serve the file non-zipped for some reason. I ended up using request

[jimmyangel]

Do you have any plans to add gzip support to this library? Thank you.

[luxalpa]

Angular's Server Side rendering depends on this project and requires GZIP support :(

[pwnall]

For Angular folks -- I'm at Google now, so I could justify spending some time on this if it's helpful to Angular. Please reach out to me if you'd like to discuss.

[moxival]

The Angular SSR can have tangible benefit receiving gzipped content as the remote requests are probably the slowest part of our project.

[benjamingr]

I patched this into my own implementation with the following diff at Testim:

             } else {
                 buffer = this._concatBuffers(this._responseParts);
             }
+            // temporary workaround for transport encoding parsing
+            if (this._responseHeaders['content-encoding'] && this._responseHeaders['content-encoding'] === 'gzip') {
+                buffer = require('zlib').gunzipSync(buffer);
+            }
+            console.log('response parse', this._responseHeaders);
             this._responseParts = null;
             switch (this.responseType) {
                 case 'text':

Feel free to use this (it's very basic and mostly incorrect since it doesn't stream the zipped data), a more correct implementation would reuse the logic for this from superagent or request.

It worked for me, feel free to use this.

[mahpour]

I patched this into my own implementation with the following diff at Testim:

             } else {
                 buffer = this._concatBuffers(this._responseParts);
             }
+            // temporary workaround for transport encoding parsing
+            if (this._responseHeaders['content-encoding'] && this._responseHeaders['content-encoding'] === 'gzip') {
+                buffer = require('zlib').gunzipSync(buffer);
+            }
+            console.log('response parse', this._responseHeaders);
             this._responseParts = null;
             switch (this.responseType) {
                 case 'text':

Feel free to use this (it's very basic and mostly incorrect since it doesn't stream the zipped data), a more correct implementation would reuse the logic for this from superagent or request.

It worked for me, feel free to use this.

Can you please explain where/how this should be applied?

[benjamingr]

This is a diff file, you can typically apply it with the patch command http://man7.org/linux/man-pages/man1/patch.1.html

[mahpour]

This is a diff file, you can typically apply it with the patch command http://man7.org/linux/man-pages/man1/patch.1.html

I understand. but which file?

[mahpour]

I figured it out. I used the script patching to apply the patch after npm install.
Thanks to John Liu from:
http://johnliu.net/blog/2018/12/hot-patching-our-dependencies-with-patch-package

[RomanChygryn]

Is this still not supported by Angular Universal?
Logs from ssr throws mi this error Refused to set unsafe header "Accept-Encoding"
I added "Accept-Encoding" header to all requests to enable gzip.

I need to know if i understand correctly: Angular Universal use xhr2 for all requests, and xhr2 not support gzip, thats what my ssr refuse "Accept-Encoding" header, i'm right?

[amakhrov]

"Accept-Encoding" is not supposed to be set manually at all. Instead, user agent is expected to set it automatically for all outgoing requests, based on what this user agent really supports.

Now, the real question is - does xhr2 support decoding gzipped responses? If yes - it should set this header automatically. Otherwise - curious to know if there are any plans to start supporting it.

[mahpour]

I checked xhr2 used in angular 9 universal and it still doesn’t support gzip decompression. I had to create a new patch file and use it in our build process.