Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uriescape function deprecated on P7 - no alternative on P8 #1401

Open
traylenator opened this issue Oct 13, 2023 · 2 comments · May be fixed by #1402
Open

uriescape function deprecated on P7 - no alternative on P8 #1401

traylenator opened this issue Oct 13, 2023 · 2 comments · May be fixed by #1402
Labels
community

Comments

@traylenator
Copy link
Contributor

Describe the Bug

With puppet 8

# --- Caused by: ---
      # Puppet::ParseError:
      #   Puppet: This function is not available in Puppet 8. URI.escape no longer exists as of Ruby 3+.
      #   ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/uriescape.rb:23:in `block in <module:Functions>'

Environment

  • Puppet 8

I don't see any alternative function to use ?
@traylenator
Copy link
Contributor Author

This rfc2396_escape is not exposed to puppet is it ?

puppetlabs/puppet@41dcae7

@traylenator
Copy link
Contributor Author 

inline_template('<%= (URI::Parser.new).escape(@_algo) %>')

works okay.

traylenator added a commit to traylenator/puppetlabs-stdlib that referenced this issue Oct 17, 2023
@traylenator
Revert "(CONT-801) Deprecate uriescape.rb"
6da5a2f 
This reverts commit 799d608.

While uriescape was deprecated for Puppet 8 in puppetlabs#1307
it was already fixed earlier for Puppet 8 and ruby 3 in puppetlabs#1195

It is unclear to me why this function was deprecated.

* Fixes puppetlabs#1401
@traylenator traylenator linked a pull request Oct 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "(CONT-801) Deprecate uriescape.rb" traylenator/puppetlabs-stdlib
2 participants
@traylenator @ia-content