Add simple stack trace on unhandled exception #78
Conversation
|
Tested this on windows. Did not seem to work for me unfortunately :( |
|
Hmm. I did not try this on Windows, but I don't see any reason why this wouldn't work on Windows. Is the Can you try enabling the |
|
Honestly I'm having a lot of trouble telling whether the function is being called at all. If I run it in debug mode in VS, it stalls on the exception itself and never gets there. And if I run the compiled version it just crashes and I don't see anything. I tried adding logging in the function but it's always possible it is calling the loggers but terminating the app too fast for them to get written? You can see what I've tried in the PR link I sent before. It's very possible I'm doing something wrong |
|
I'll check it out on Windows when I have some free time |
|
I did fix one issue where the path was all borked up on Windows, but, like yourself, I cannot get Feel free to close this pr until then. |
|
Thanks for checking. I think it's fine to keep open as this is a feature we would really like. |
This leverages wxStackWalker and the OnFatalException handler to access frames and their associated data
On windows, it can be the case, that the path returned by File::GetExeDirectory does not end in a directory seperator This will *hopefully* ensure that this is not the case
|
I have an idea as to what the issue could be but I cannot get a local build running due to my inability to duck the "Precompiled Header Setting" My idea was this, if you want to try it yourself pending my testing: I read somewhere on wxWidget's documentation that OnFatalException depends on a compiling with Structured Exception Handling as a feature. This is a feature in Visual Studio. See this Microsoft documentation on the option here: Now, here comes the janky part. I tried doing this for myself after rebasing my branch on upstream slippi, but I cannot get it to compile. It always says I tried disabling PCH and then get hit with even more errors, so I decided to stop there for now. You might try enabling this yourself and see if you can get past this error. With any luck, this is what's preventing this feature from working on Windows. |
|
@legionxvx Did you update to VS2019? Wondering if that's why you encountered errors. Fwiw Dolphin doesn't support C++ exceptions afaik, you can't use try/catch |
|
Closing due to inactivity. |
Fixes #43
This leverages wxStackWalker and the OnFatalException handler to
access frames and their associated data