Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slippi Dolphin uses GTK on KDE Plasma (Qt Desktop) whilst Upstream uses Qt #415

Open
Jazztache opened this issue Nov 22, 2023 · 5 comments

Comments

@Jazztache
Copy link

Summary

Stock Dolphin (namely the AUR build) uses Qt 6.6 for it's UI. However, it seems that Slippi Dolphin is using GTK, being translated to GTK somehow. This is using the current build of Slippi, an up-to-date install of Arch, on the official AppImage on the Slippi website.

Expected Behavior

Slippi Dolphin should look exactly the same as regular Dolphin Emulator.

Current Behavior

Slippi uses GTK to display it's UI in contrast to the stock build of Dolphin which uses Qt.

Steps to Reproduce

  1. Install Slippi
  2. Install Stock Dolphin from the AUR
  3. Open both and compare.

Video Example

https://youtu.be/kpJ_UrKqyMQ

Environment

KDE Plasma on Arch Linux 6.6.2-arch1-1

Extra Notice

Currently, KDE Plasma Breeze is behind a version for theming. This is why Fusion instead of Breeze is used for Stock Dolphin's theme. Once Plasma 6 releases, this will fix itself.

@ryanmcgrath
Copy link
Collaborator

ryanmcgrath commented Nov 22, 2023

Ishiiruka (the fork that Slippi's stable build uses) is old and uses GTK via wxWidgets - nothing is being translated.

The mainline beta is using QT since it's what mainline Dolphin uses. That's the future, there is likely nothing that'll change in Ishii.

Edit: Slippi Dolphin should look exactly the same as regular Dolphin Emulator. <--- I also suspect this'll never be a hard and fast rule, since they are separate projects.

@Jazztache
Copy link
Author

Would it be out of the question for (maybe sometime much further in the future) for Ishiiruka to be rebased on the latest Dolphin build? wxWidgets seems to be out of date from what I can gather and it might be a good idea to consider it if UI technical debt every becomes an issue.

Also clarifying the whole exactly the same thing, obviously some tabs and buttons will be moved and changed, but mainly the UI toolkit should be the same, so that desktop themes can integrate properly.

@ryanmcgrath
Copy link
Collaborator

I think you've misunderstood my comment: Ishiiruka would ultimately just not be a factor once the mainline-Slippi beta build becomes the official Slippi build (whenever it happens, there is no official ETA). That is effectively the rebased version.

These are already usable via the Slippi Launcher, etc.

@Jazztache
Copy link
Author

Oh! So there's an active beta branch/seperate build that is based on an up-to-date build of Dolphin? Sign me up! :D Where do I go to get it?

@cobalt2727
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants