From 782f7ea98f164c886895eb13a28d585813f4d536 Mon Sep 17 00:00:00 2001 From: David Grove Date: Wed, 5 Feb 2025 08:28:56 -0500 Subject: [PATCH] use standalone configuration/tests for devmode tests for CI (#309) we're not faking the kueue webhook in the controller, so the devmode tests need to be changed to standalone (no kueue) --- .github/workflows/CI-devmode.yaml | 3 --- config/dev/config.yaml | 2 +- docs/release_instructions.md | 3 +-- hack/run-dev-mode-tests.sh | 2 +- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/CI-devmode.yaml b/.github/workflows/CI-devmode.yaml index b452989a..ceab055b 100644 --- a/.github/workflows/CI-devmode.yaml +++ b/.github/workflows/CI-devmode.yaml @@ -49,9 +49,6 @@ jobs: - name: Create and configure cluster run: ./hack/create-test-cluster.sh - - name: Deploy Kueue - run: ./hack/deploy-kueue.sh - - name: Install CRDs run: | make install -e GIT_BRANCH=${{ env.GIT_BRANCH }} TAG=${{ env.GIT_BRANCH }}-${{ env.TAG }} diff --git a/config/dev/config.yaml b/config/dev/config.yaml index 97f09484..6c04c306 100644 --- a/config/dev/config.yaml +++ b/config/dev/config.yaml @@ -5,7 +5,7 @@ metadata: data: config.yaml: | appwrapper: - enableKueueIntegrations: true + enableKueueIntegrations: false controllerManager: health: bindAddress: "localhost:0" diff --git a/docs/release_instructions.md b/docs/release_instructions.md index 0cc70246..b0c58c0e 100644 --- a/docs/release_instructions.md +++ b/docs/release_instructions.md @@ -16,8 +16,7 @@ will: + create a [GitHub release](https://github.com/project-codeflare/appwrapper/releases) that contains the install.yaml 4. Update the kustomization.yaml files in MLBatch to refer to the new release: - + setup.k8s-v1.27/appwrapper/kustomization.yaml - + setup.k8s-v1.30/appwrapper/kustomization.yaml + + setup.k8s/appwrapper/kustomization.yaml 4. To workaround back level go versions in ODH, we also maintain a codeflare-releases branch. After making a release, merge main diff --git a/hack/run-dev-mode-tests.sh b/hack/run-dev-mode-tests.sh index a3b0399c..2da92829 100755 --- a/hack/run-dev-mode-tests.sh +++ b/hack/run-dev-mode-tests.sh @@ -35,7 +35,7 @@ run () { } NAMESPACE=dev go run ./cmd/main.go & -run $! go run github.com/onsi/ginkgo/v2/ginkgo -v -fail-fast --procs 1 -timeout 130m --label-filter=Kueue ./test/e2e +run $! go run github.com/onsi/ginkgo/v2/ginkgo -v -fail-fast --procs 1 -timeout 130m --label-filter=Standalone ./test/e2e RC=$? if [ ${RC} -eq 0 ]