Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated setDaemon API #171

Open
gmacon opened this issue Jan 12, 2024 · 4 comments
Open

Use of deprecated setDaemon API #171

gmacon opened this issue Jan 12, 2024 · 4 comments
Assignees
Labels
active bug something broken P3 not needed for current cycle

Comments

@gmacon
Copy link

gmacon commented Jan 12, 2024

In Python 3.10, the isDaemon/setDaemon API on Thread was deprecated in favor of just using the daemon attribute directly. This produces this warning during tests:

  .../site-packages/kaleido/scopes/base.py:188: DeprecationWarning:
  
  setDaemon() is deprecated, set the daemon attribute instead
@amgcc
Copy link

amgcc commented Jan 22, 2024

Are there any plans to release a new version of streamlit? This is fixed on the master branch but not available to conda users.

@gvwilson
Copy link
Collaborator

Thanks for your interest in Kaleido. We are currently working on an overhaul that might address your issue - we hope to have news in a few weeks and will post an update then. Thanks - @gvwilson

@gvwilson gvwilson removed their assignment Aug 3, 2024
@gvwilson gvwilson added bug something broken P3 not needed for current cycle labels Aug 14, 2024
@YaolinGe
Copy link

YaolinGe commented Oct 25, 2024

Image
In the ~/site-packages/kaleido/scopes/base.py, Comment out line 188, and use self._std_error.thread.daemon = True seems working.

@jkittner
Copy link

This was resolved by #146 but there has not been a release since

@ayjayt ayjayt self-assigned this Nov 12, 2024
@ayjayt ayjayt added the active label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
active bug something broken P3 not needed for current cycle
Projects
None yet
Development

No branches or pull requests

6 participants