From 1f2d486ee7506126e2abdd1caf4497486b70bd6b Mon Sep 17 00:00:00 2001 From: Dom Delnano Date: Mon, 27 May 2024 21:56:52 -0700 Subject: [PATCH] Remove dry_run inputs responsible for regbot dry runs to always execute (#1923) Summary: Remove dry_run inputs responsible for regbot dry runs to always execute I attempted to fix the bug where `--dry-run` is always passed to the `regbot` cli in the mirror workflows in #1921. That attempt unfortunatley did not work, so let's remove the input and the cli argument templating entirely. Running `regbot --dry-run` locally is an easy enough mechanism for testing the workflow logic. Relevant Issues: Precursor to fixing px-sock-shop (https://github.com/pixie-io/pixie/issues/1905) Type of change: /kind bug Test Plan: Expecting that the next run off main after this change will result in mirrored demo container images Signed-off-by: Dom Del Nano --- .github/workflows/mirror_demos.yaml | 8 +------- .github/workflows/mirror_deps.yaml | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/.github/workflows/mirror_demos.yaml b/.github/workflows/mirror_demos.yaml index ab8cf89ce4b..2d434c56a5a 100644 --- a/.github/workflows/mirror_demos.yaml +++ b/.github/workflows/mirror_demos.yaml @@ -2,12 +2,6 @@ name: mirror-demos on: workflow_dispatch: - inputs: - dry_run: - description: 'Run the sync in dry-run mode' - required: false - default: false - type: boolean permissions: contents: read jobs: @@ -42,4 +36,4 @@ jobs: shell: bash run: | cd scripts/regclient - regbot once ${{ github.event.inputs.dry_run && '--dry-run' || '' }} --config regbot_demos.yaml + regbot once --config regbot_demos.yaml diff --git a/.github/workflows/mirror_deps.yaml b/.github/workflows/mirror_deps.yaml index 9d5b1fbee04..01fe6212e73 100644 --- a/.github/workflows/mirror_deps.yaml +++ b/.github/workflows/mirror_deps.yaml @@ -2,12 +2,6 @@ name: mirror-deps on: workflow_dispatch: - inputs: - dry_run: - description: 'Run the sync in dry-run mode' - required: false - default: false - type: boolean permissions: contents: read jobs: @@ -42,4 +36,4 @@ jobs: shell: bash run: | cd scripts/regclient - regbot once ${{ github.event.inputs.dry_run && '--dry-run' || '' }} --config regbot_deps.yaml + regbot once --config regbot_deps.yaml