Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and Update Plugin JavaScript Files #66

Closed
mwbrooks opened this issue May 29, 2014 · 8 comments
Closed

Audit and Update Plugin JavaScript Files #66

mwbrooks opened this issue May 29, 2014 · 8 comments
Milestone

Comments

@mwbrooks
Copy link
Collaborator

It looks as though some of the plugin JavaScript files bundled in connect-phonegap are not the same as those bundled in the phonegap-app-developer. It's important the the files are identical because it's plugins often update the JavaScript between versions.

Let's resync (e.g. copy from phonegap-app-developer) all of the files found in: /res/middleware/cordova

@mwbrooks
Copy link
Collaborator Author

Reference: phonegap/phonegap-app-developer#134

@mwbrooks
Copy link
Collaborator Author

PhoneGap Developer App 1.0.0

mwbrooks added a commit that referenced this issue May 29, 2014
The PhoneGap Developer App 1.0.0 ships with [email protected].

The resources were mistakenly labelled as 3.4.0 in connect-phonegap.
@mwbrooks
Copy link
Collaborator Author

In the PhoneGap Developer App, I checked out each platform's production tag, built the app, and copied the cordova.js, cordova_plugins.js, and plugins/**/*.js files into the resource directory.

I reviewed each file. For cordova.js, I kept a patch that fixed loading off the URL. This is required to properly run mobile-spec. For cordova_plugins.js, I kept the .metadata definition because it's handy and has no impact on functionality. The rest I reverted to become synchronized with the PhoneGap Developer App.

Both iOS and WP8 had incorrect files. Android matched correctly.

@mwbrooks
Copy link
Collaborator Author

Tested on:

  • Android Galaxy Nexus
  • iOS iPhone 5
  • WP8 Nokia 920

Cordova's deviceready event fires and basic APIs such as accelerometer, compass, and network function correctly.

However, some APIs such as battery status and File do not work on some platforms. The JavaScript platform updates don't appears to have caused the problem because the production version of connect-phonegap shows the same issues.

@mwbrooks
Copy link
Collaborator Author

Windows Phone 8

  • Accelerometer: works
  • Audio Play/Record: works
  • Battery: works (must wait for the battery level to change by 1%)
  • Camera: not working
  • Capture: not working
  • Compass: working
  • Contacts: working
  • Events: working
  • Location: working
  • Networking: working
  • Notification: working
  • Splashscreen: working
  • InAppBrowser: working
  • Vibration: working
  • File API: not working (according to mobile-spec) -- test further

@mwbrooks
Copy link
Collaborator Author

iOS

  • Accelerometer: working
  • Audio Play/Record: working
  • Battery: works
  • Camera: not working (works with DATA_URL)
  • Capture: not working (claims success but the image is broken)
  • Compass: working
  • Contacts: working
  • Events: working
  • Location: working
  • Network: working
  • Notification: working
  • Splashscreen: working
  • InAppBrowser: working
  • File API: not working (according to mobile-spec) -- test further

@mwbrooks
Copy link
Collaborator Author

Android

  • Accelerometer: working
  • Audio Play/Record: working
  • Battery: working
  • Camera: not working (works with DATA_URL)
  • Capture: not working (claims success but the image is broken)
  • Compass: working
  • Contacts: working
  • Events: working
  • Location: working
  • Network: working
  • Notification: working
  • Splashscreen: working (but it is disabled for the PG App)
  • InAppBrowser: working
  • File API: not working (according to mobile-spec) -- test further

mwbrooks added a commit that referenced this issue Jun 3, 2014
The PhoneGap Developer App 1.0.0 ships with [email protected].

The resources were mistakenly labelled as 3.4.0 in connect-phonegap.
mwbrooks added a commit that referenced this issue Jun 6, 2014
…P8 3.5.0

- WP8 already had the correct JS file.
timkim added a commit to timkim/connect-phonegap that referenced this issue Jun 12, 2014
timkim added a commit to timkim/connect-phonegap that referenced this issue Jun 17, 2014
timkim added a commit to timkim/connect-phonegap that referenced this issue Jun 18, 2014
@mwbrooks mwbrooks added this to the Backlog milestone Sep 16, 2015
@filmaj
Copy link
Collaborator

filmaj commented Apr 21, 2017

From what I understand, with content-sync these files are no longer needed. Filed #190 to remove these files in a future release.

@filmaj filmaj closed this as completed Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants