From ce2fc06e6fb42c5d496c7c8d1ceaa4f247df7f42 Mon Sep 17 00:00:00 2001 From: Marton Lederer Date: Fri, 9 Aug 2024 14:54:56 +0200 Subject: [PATCH 1/4] fix: AoLoader initializer types --- loader/src/index.cjs | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/loader/src/index.cjs b/loader/src/index.cjs index ce064d135..f4c1f30bf 100644 --- a/loader/src/index.cjs +++ b/loader/src/index.cjs @@ -69,19 +69,24 @@ const Wasm64 = require('./formats/wasm64-emscripten.cjs') * @returns {HandleResponse} */ +/** + * @typedef {'wasm32-unknown-emscripten'| + * 'wasm32-unknown-emscripten2'| + * 'wasm32-unknown-emscripten3'| + * 'wasm64-unknown-emscripten-draft_2024_02_15'} BinaryFormat + */ + /** * @typedef Options - * @property {string} format - * @property {string} input - * @property {string} output - * @property {string} memory - * @property {string} compute - * @property {String[]} extensions + * @property {BinaryFormat} [format] + * @property {number} [computeLimit] + * @property {string} [memoryLimit] + * @property {string[]} [extensions] */ /** * @param {ArrayBuffer} binary - * @param {Options} options + * @param {Options} [options] * @returns {Promise} */ module.exports = async function (binary, options) { From 5ca7d67b6acd09cfb9515dcca14f39cac13320b1 Mon Sep 17 00:00:00 2001 From: Marton Lederer Date: Fri, 9 Aug 2024 15:04:52 +0200 Subject: [PATCH 2/4] fix: handleFunction types --- loader/src/index.cjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/loader/src/index.cjs b/loader/src/index.cjs index f4c1f30bf..6aad7ae3f 100644 --- a/loader/src/index.cjs +++ b/loader/src/index.cjs @@ -63,10 +63,10 @@ const Wasm64 = require('./formats/wasm64-emscripten.cjs') /** * @callback handleFunction - * @param {ArrayBuffer | NULL} buffer + * @param {ArrayBuffer | null} buffer * @param {Message} msg * @param {Environment} env - * @returns {HandleResponse} + * @returns {Promise} */ /** From ddcd394a2fd34ecf789e3d14dc86068f75d1d26e Mon Sep 17 00:00:00 2001 From: Marton Lederer Date: Fri, 9 Aug 2024 15:05:48 +0200 Subject: [PATCH 3/4] fix: environment types --- loader/src/index.cjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/loader/src/index.cjs b/loader/src/index.cjs index 6aad7ae3f..057bdbc21 100644 --- a/loader/src/index.cjs +++ b/loader/src/index.cjs @@ -49,7 +49,7 @@ const Wasm64 = require('./formats/wasm64-emscripten.cjs') /** * @typedef Environment - * @property {{id: string, owner: string, tags: Tag[]}} process + * @property {{Id: string, Owner: string, Tags: Tag[]}} Process */ /** From 6e3db4ad803fc4b5f27505c0a8944ed511157d87 Mon Sep 17 00:00:00 2001 From: Marton Lederer Date: Fri, 9 Aug 2024 15:07:43 +0200 Subject: [PATCH 4/4] fix: point to the correct types for AoLoader --- loader/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/loader/package.json b/loader/package.json index 635db8c55..531317717 100644 --- a/loader/package.json +++ b/loader/package.json @@ -9,7 +9,7 @@ "sideEffects": false, "type": "module", "main": "./dist/index.cjs", - "types": "./dist/index.d.ts", + "types": "./dist/index.d.cts", "files": [ "./dist" ],