Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cu): return previous assignment evaluation on duplicate #1091

Open
jfrain99 opened this issue Dec 18, 2024 · 0 comments · May be fixed by #1103
Open

fix(cu): return previous assignment evaluation on duplicate #1091

jfrain99 opened this issue Dec 18, 2024 · 0 comments · May be fixed by #1103
Assignees

Comments

@jfrain99
Copy link
Contributor

Background

In the CU, when a duplicate assignment is received in the eval stream (that is, an assignment of a tx that has been previously assigned), the CU currently does some work and removes this evaluation from the eval stream.

Problem

This is non-optimal, as the work being done can be avoided.

Proposed Solution

Before initializing our eval stream (in the function maybeExactEval, search the evaluations sqlite table by processId and messageId to find previous instance of this assignment. If it exists, return the result of the previous evaluation and continue.

@jfrain99 jfrain99 self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant