Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pov-export to slot-based collator #7573

Open
skunert opened this issue Feb 14, 2025 · 2 comments · May be fixed by #7585
Open

Add pov-export to slot-based collator #7573

skunert opened this issue Feb 14, 2025 · 2 comments · May be fixed by #7585
Assignees
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@skunert
Copy link
Contributor

skunert commented Feb 14, 2025

In the lookahead collator we have support for the --export-pov-path CLI arg. For some debugging scenarios, this will export PoVs that are send to the relay chain to the local file system.

if let Some(ref export_pov) = export_pov {

The slot-based collator does not currently support this, so we should add it.

Needs to be added to the params:

pub struct SpawnTasksParams<'a, TBl: BlockT, TCl, TExPool, TRpc, Backend> {

Then we need to export it in the collation-task:

tracing::debug!(target: LOG_TARGET, ?core_index, %hash, %number, "Submitting collation for core.");

@skunert skunert added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Feb 14, 2025
@skunert skunert added this to SDK Node Feb 14, 2025
@github-project-automation github-project-automation bot moved this to backlog in SDK Node Feb 14, 2025
@MrishoLukamba
Copy link
Contributor

MrishoLukamba commented Feb 14, 2025

taking it @skunert

@MrishoLukamba
Copy link
Contributor

In the lookahead collator we have support for the --export-pov-path CLI arg. For some debugging scenarios, this will export PoVs that are send to the relay chain to the local file system.

polkadot-sdk/cumulus/client/consensus/aura/src/collators/lookahead.rs

Line 444 in 3b2a1db

if let Some(ref export_pov) = export_pov {
The slot-based collator does not currently support this, so we should add it.

Needs to be added to the params:

polkadot-sdk/substrate/client/service/src/builder.rs

Line 359 in 1866c3b

pub struct SpawnTasksParams<'a, TBl: BlockT, TCl, TExPool, TRpc, Backend> {
Then we need to export it in the collation-task:

polkadot-sdk/cumulus/client/consensus/aura/src/collators/slot_based/collation_task.rs

Line 150 in 1866c3b

tracing::debug!(target: LOG_TARGET, ?core_index, %hash, %number, "Submitting collation for core.");

I do not think the params for exporting should be set inside SpawnTaskParams as that it is in substrate client and not cumulus client and the context is POV.
Opening a PR soon to see what I have done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
Status: backlog
Development

Successfully merging a pull request may close this issue.

3 participants
@skunert @MrishoLukamba and others