Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon Secrets Guide Doc Update #9425

Open
Matt-B50 opened this issue Feb 9, 2025 · 1 comment
Open

Pantheon Secrets Guide Doc Update #9425

Matt-B50 opened this issue Feb 9, 2025 · 1 comment

Comments

@Matt-B50
Copy link

Matt-B50 commented Feb 9, 2025

Re: Pantheon Secrets Guide

Priority: Low

Issue Description:

Incorrect composer useage? composer require-dev pantheon-systems/customer-secrets-php-sdk results in the error Command "require-dev" is not defined.

Suggested Resolution

composer require --dev pantheon-systems/customer-secrets-php-sdk

@rachelwhitton
Copy link
Member

rachelwhitton commented Feb 12, 2025

thanks for opening this issue! you're correct, we'll make this update shortly. along with some additional improvements for clarity:

  • move drupal-specific section to the top
  • be explicit wrt scenarios like wp only
  • consider also re-ordering the page and adding a prompt to create a secret first.
    • validate that existing secrets are populated when running terminus secret:site:local-generate <site>
  • review codeblock for the following:

Instructions for Lando do not work. I don't get any errors, but I also don't get any secrets! I think this relates to the if ( ! function_exists( 'pantheon_get_secret' ) ) {...} code block

assigning to @jazzsequence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants