Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cross-domain libraries #15

Open
maxrjones opened this issue Sep 10, 2024 · 7 comments
Open

Add missing cross-domain libraries #15

maxrjones opened this issue Sep 10, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@maxrjones
Copy link
Member

Cross-domain libraries are rendered from the list here - https://github.com/pangeo-data/pangeo.io/blob/main/src/data/core-libraries.js. This issue is to add any missing libraries (e.g., Jupyter)

@maxrjones maxrjones added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 10, 2024
@TomNicholas
Copy link
Member

TomNicholas commented Sep 11, 2024

I was going to say Jupyter. Also VirtualiZarr / Kerchunk are technically cross-domain.

EDIT: XPublish

@TomNicholas
Copy link
Member

TomNicholas commented Sep 11, 2024

Also all the other distributed array packages (xarray-beam and cubed, hopefully at some point arkouda)

EDIT: But this begs the question of how mature something should be before we advertise it...

ofk123 added a commit to ofk123/pangeo.io that referenced this issue Nov 14, 2024
@ofk123
Copy link
Contributor

ofk123 commented Nov 14, 2024

Hi @maxrjones @TomNicholas and others, I found some time to have a go at this and #16, by some quick copy-pasting and converting logos from different formats. (Not saying it is complete)

  • Obviously not all packages have logos yet, but I added the logos you made @maxrjones. I dont know if it is supposed to be used yet? It is really cool.

  • Also no idea how it ends up rendering, is there a way you check before syncs? As this was just a suggestion, please let me know how to edit this further if you want? Thanks in advance.

  • It does beg that question @TomNicholas, these lists will become quite long ... I started thinking a "horizontal scrolling function" or something similar would have been nice, unless its only meant to showcase a few mature packages

@maxrjones
Copy link
Member Author

Hi @maxrjones @TomNicholas and others, I found some time to have a go at this and #16, by some quick copy-pasting and converting logos from different formats. (Not saying it is complete)

That's awesome, thank you for working on this! It would be great to see a PR whenever you're ready.

  • Obviously not all packages have logos yet, but I added the logos you made @maxrjones. I dont know if it is supposed to be used yet? It is really cool.

It's great to hear people like the proposed logo. I'll ask about it in tomorrow's VirtualiZarr meeting, but I think it'd need to go through a review/feedback process before being finalized.

  • Also no idea how it ends up rendering, is there a way you check before syncs? As this was just a suggestion, please let me know how to edit this further if you want? Thanks in advance.

Yeah, these instructions detail how to show the current changes in your browser. Let me know if you have questions.

ofk123 added a commit to ofk123/pangeo.io that referenced this issue Nov 15, 2024
xbatcher, xarray-beam, intake
ref pangeo-data#15
@ofk123
Copy link
Contributor

ofk123 commented Nov 15, 2024

  • Thanks, rendering locally, it looks allright at first glance. Only need some advice on how to only render {library.logo} when logo exists, for example for XPublish, Cubed and more. And maybe you want to design even more logos Max...
  • Yes, let me know what the conclusion is on the logo from the VirtualiZarr-meeting, thanks!

@maxrjones
Copy link
Member Author

Thanks, rendering locally, it looks allright at first glance. Only need some advice on how to only render {library.logo} when logo exists, for example for XPublish, Cubed and more. And maybe you want to design even more logos Max...

I think you could change https://github.com/pangeo-data/pangeo.io/blob/main/src/components/mdx/image.js to return null if src doesn't exist, similar to how DOIs are handled:

if (!doi) return null

Yes, let me know what the conclusion is on the logo from the VirtualiZarr-meeting, thanks!

Sorry, I forgot to ask. I would recommend leaving it off for now

@ofk123
Copy link
Contributor

ofk123 commented Nov 16, 2024

  • Yes, that seems to work, thanks @maxrjones.
  • Leaving it off for now.

EDIT: Opening a request to see if it works. List of libraries will not be complete though. Need some feedback on what else to add or edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants