Yarn PnP

[Boshen]

https://yarnpkg.com/features/pnp

Please +1 and link your public repository if you're using yarn pnp.

[Boshen]

https://github.com/sveltejs/kit/issues/11578#issuecomment-1884974247

Yarn PnP is broken, and we don't support it — if it ever worked, it was by accident. It is a frequent source of misery for OSS maintainers, and we strongly recommend using nodeLinker: 'node-modules' or (better) just using npm/pnpm.

[ematipico]

Personally, I don't think this resolver should support Yarn PnP

[Boshen]

Please +1 and link your public repository if you're using yarn pnp.

Please link your project with yarn pnp setup here for the possibility of reopening this issue.

Personally, I don't think this resolver should support Yarn PnP

We can provide yarn pnp support with a feature flag.

Supporting yarn pnp is a big maintenance burden for us, but I'm happy to add another maintainer who is willing to implement, maintain and triage issues related with yarn pnp, since triaging a resolution error usually takes an hour at least.

If I get a bug report that looks similar to the 120+ open issues in yarn relating to pnp, how much time should I spend on triaging them? https://github.com/search?q=repo%3Ayarnpkg%2Fberry+pnp++&type=issues&state=open

[BasixKOR]

Probably the biggest and most useful reference for Yarn monorepo would be Yarn itself: https://github.com/yarnpkg/berry

AFAIK Yarn (berry) is still used well on corporate projects due to its highly configurable nature but hasn't seen wide usage outside of it. I'd love to help this issue but I think I should look more deep into oxc before promising anything ;)

[arcanis]

Note that I implemented a PnP resolver in Rust as a package: https://github.com/arcanis/pnp-rust; I had a prototype integrating it with Parcel and the work was quite minimal.

So if you're interested, I'm more than happy to help integrate the pnp-rs crate with oxc, and move it to the official yarnpkg org so it keeps being maintained in the future.

If I get a bug report that looks similar to the 120+ open issues in yarn relating to pnp, how much time should I spend on triaging them? https://github.com/search?q=repo%3Ayarnpkg%2Fberry+pnp++&type=issues&state=open

The repo issues aren't the right metric - rather, the interesting one is Esbuild, which has natively supported PnP for a while. There's been ~60 issues in ~3 years, most of them closed. In your case it'd be lower if you leveraged the pnp-rs crate, as we'd take ownership of many of these issues.

[Boshen]

Note that I implemented a PnP resolver in Rust as a package: https://github.com/arcanis/pnp-rust; I had a prototype integrating it with Parcel and the work was quite minimal.

So if you're interested, I'm more than happy to help integrate the pnp-rs crate with oxc, and move it to the official yarnpkg org so it keeps being maintained in the future.

If I get a bug report that looks similar to the 120+ open issues in yarn relating to pnp, how much time should I spend on triaging them? https://github.com/search?q=repo%3Ayarnpkg%2Fberry+pnp++&type=issues&state=open

The repo issues aren't the right metric - rather, the interesting one is Esbuild, which has natively supported PnP for a while. There's been ~60 issues in ~3 years, most of them closed. In your case it'd be lower if you leveraged the pnp-rs crate, as we'd take ownership of many of these issues.

Thank you @arcanis. The pnp-rs crate + redirecting issues is a good solution.

Let's collaborate and integrate. Just ping me if you need anything from me.

[Boshen]

The Rust side is complete.

For future reference:

• Calling require.resolve('pnpapi') will return the path to the current .pnp.cjs file
• Calling require('module').findPnpApi?.(cwd) will crawl the filesystem starting from cwd (which can be __dirname, process.cwd(), ...)

Rust option is

oxc-resolver/src/options.rs

Line 122 in 5310589

pub pnp_manifest: Option<pnp::Manifest>,

Feature is

oxc-resolver/Cargo.toml

Lines 105 to 106 in 5310589

	## [Yarn Plug'n'Play](https://yarnpkg.com/features/pnp)
	yarn_pnp = ["pnp"]

[Boshen]

Now I need a collaborator to help me test this in their tool.

[psychobolt]

I'm willing to test, but I'm not a contributor. I am looking to set the resolution for @swc-node/register/oxc-resolver@npm:??? to point to a version that includes this fix.

[Boshen]

This is now behind a feature flag

oxc-resolver/Cargo.toml

Lines 105 to 106 in 509dc00

	## [Yarn Plug'n'Play](https://yarnpkg.com/features/pnp)
	yarn_pnp = ["pnp"]

Feel free to create an issue for integration.