Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "StepTime" occurrences (Backend) #68

Open
4 tasks
git-voo opened this issue Jan 27, 2025 · 2 comments · May be fixed by #69
Open
4 tasks

Refactor "StepTime" occurrences (Backend) #68

git-voo opened this issue Jan 27, 2025 · 2 comments · May be fixed by #69
Assignees
@Jaywin2099
Labels
good first issue Good for newcomers

Comments

@git-voo
Copy link
Collaborator

git-voo commented Jan 27, 2025

The researcher has decided to use Stance time instead of step time. The correct formula for stance time is what we currently have implemented for step time. So, you don't need to modify the logic for this issue, just rename files, exports/imports, methods, and texts.

Acceptance Criteria

  • All occurrences of "StepTime" in the backend are changed into "StanceTime" to match the case.
  • Methods/functions that include "Step" are renamed to "Stance"
  • Files and all import/export statements including "StepTime" are renamed to "StanceTime"
  • All existing tests pass without modification of logic
@git-voo git-voo added the good first issue Good for newcomers label Jan 27, 2025
@Br0wnHammer
Copy link

Hey, can I work on this?

@Jaywin2099 Jaywin2099 self-assigned this Jan 27, 2025
@Jaywin2099
Copy link
Collaborator

There is only one occurrence of "StepTime" literally. The vast majority of the instances are not camel-case but use "step_time". These occurrences will also be changed from "step" to "stance".

@Jaywin2099 Jaywin2099 linked a pull request Jan 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaywin2099 Jaywin2099

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix occurrences of 'step' to 'stance' oss-slu/Step_Time_Biofeedback
3 participants
@Br0wnHammer @Jaywin2099 @git-voo