-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configurable colors (themes) #4
Comments
Hey! I'm working on this right now and I'm curious as to how we want the users to set their theme? Would we have a flag for it that you need to run each time or write to some gocovsh config file in |
an environment variable would probably be the easiest |
I created a PR that works with an environment variable. The thing is, it's not fully working. I'm getting a nil pointer error - shown in the demo GIF attached to the PR |
Are further contributions adding themes welcome? Or should a more modular approach, which doesn't require adding Code for every new theme, be used? |
Hey @thelooter and sorry for taking so long to respond here. Theme and other contributions are welcome. I have a task somewhere to support configurable theme files so that no code changes are required to customize the looks, but it would require refactoring of existing code. I'll be happy to accept both "hard coded" themes and externally configurable themes if you still wish to work on this. |
No description provided.
The text was updated successfully, but these errors were encountered: