TestRecover fail

[fungaren]

Which jobs are failing:

Which test(s) are failing:

pkg/yurthub/cachemanager/error_keys_test.go

--- PASS: TestXxx (0.00s)
    --- PASS: TestXxx/test1 (0.00s)
=== RUN   TestRecover
    error_keys_test.go:109: failed to recover
--- FAIL: TestRecover (0.00s)
=== RUN   TestCompress

Since when has it been failing:

Testgrid link:

Reason for failure:

These two tests share the same variable AOFPrefix.

The result of Unmarshal() is not checked.

https://github.com/openyurtio/openyurt/blob/v1.5.0/pkg/yurthub/cachemanager/error_keys.go#L235

Actually the data in the /tmp/errorkeys/aof is:

{"Operator":"put","Key":"kubelet","Val":"fail to xxx"}perator":"put","Key":"key-31","Val":"value-31"}
{"Operator":"put","Key":"key-32","Val":"value-32"}
{"Operator":"put","Key":"key-34","Val":"value-34"}
...

Because of the wrong open mode os.O_CREATE|os.O_RDWR, it should has O_TRUNC to make the file clean.

Anything else we need to know:

labels

/kind failing-test

[luc99hen]

@vie-serendipity Please take a look

[vie-serendipity]

@fungaren This is indeed a bug. Are you willing to fix it?

[fungaren]

@vie-serendipity Sorry I am afraid I can't, because I have not read the related code carefully.

[vie-serendipity]

@fungaren ok, thanks for spotting this bug. I'll fix that later on.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.