From 429c576056f82eaeb52f85fb4692afe8d584c8c1 Mon Sep 17 00:00:00 2001 From: Dimitris Vardoulakis Date: Fri, 14 Feb 2025 01:11:17 -0800 Subject: [PATCH] PR #22645: Fix error in the gpu_specs README. The spec is the TargetConfig, which includes the device description. Imported from GitHub PR https://github.com/openxla/xla/pull/22645 Copybara import of the project: -- 5fefad4bdb1b947844c7c2d8ff1029f5c99aace5 by Dimitris Vardoulakis : Fix error in the specs README. The spec is the TargetConfig, which includes the device description. -- 39f8e9f343de45b4678a6760b9a9720d48163299 by Dimitris Vardoulakis : Update xla/tools/hlo_opt/gpu_specs/README.md Co-authored-by: Allan Renucci Merging this change closes #22645 COPYBARA_INTEGRATE_REVIEW=https://github.com/openxla/xla/pull/22645 from dimvar:add-readme-to-gpu_specs 39f8e9f343de45b4678a6760b9a9720d48163299 PiperOrigin-RevId: 726817625 --- xla/tools/hlo_opt/gpu_specs/README.md | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/xla/tools/hlo_opt/gpu_specs/README.md b/xla/tools/hlo_opt/gpu_specs/README.md index 6586c2fbe3ca2..90a62a563248f 100644 --- a/xla/tools/hlo_opt/gpu_specs/README.md +++ b/xla/tools/hlo_opt/gpu_specs/README.md @@ -1,7 +1,9 @@ -The specs in this folder are obtained by calling the appropriate override of -`StreamExecutor::CreateDeviceDescription`, then turned into -`GpuDeviceInfoProto`. (E.g., for NVIDIA GPUs, we call -`CudaExecutor::CreateDeviceDescription`.) The specs are useful when compiling -with the flag `--xla_gpu_target_config_filename`. Since a hardware generation -may have several SKUs, a spec may not be identical to what we would get on a -particular machine, but it will be "close enough". +The specs in this folder are obtained by calling +`Compiler::TargetConfig::ToString()`, which turns the config into a +`GpuTargetConfigProto`, and then to a `std::string`. Most of the spec is the +device description as a proto `GpuDeviceInfoProto`. + +The specs are useful when compiling with the flag +`--xla_gpu_target_config_filename`. Since a hardware generation may have several +SKUs, a spec may not be identical to what we would get on a particular machine, +but it will be "close enough".