Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support *_PROXY env variables #137

Open
DenisBY opened this issue Dec 18, 2023 · 4 comments · May be fixed by #217
Open

[FEATURE] Support *_PROXY env variables #137

DenisBY opened this issue Dec 18, 2023 · 4 comments · May be fixed by #217
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DenisBY
Copy link

DenisBY commented Dec 18, 2023

Is your feature request related to a problem?

I tried to debug the provider using mitm proxy with HTTPS_PROXY=http://localhost:8080 terraform apply and was very confused when I didn't find any connections to OS from the provider until I specified proxy= option in config

What solution would you like?

The provider should support proxy config from *_PROXY env variables beside proxy= option
@DenisBY DenisBY added enhancement New feature or request untriaged labels Dec 18, 2023
@prudhvigodithi
Copy link
Member

[Untriage]
Hey @DenisBY can you please share the full config (the .tf file you are using?) is the OS cluster behind a reverse proxy or you are trying to access the cluster thought a proxy ?
Adding @timwisbauer-contsec as we contributed the proxy support feature.
Thank you

@prudhvigodithi prudhvigodithi added good first issue Good for newcomers and removed untriaged labels Dec 20, 2023
@DenisBY
Copy link
Author

DenisBY commented Jan 9, 2024

Hi. I was trying to debug one thing and used MITM proxy via HTTPS_PROXY=http://localhost:8080 terraform apply command and was wonder, why I can see connections only from terraform itself and from aws provider and nothing from opensearch provider. And only after some digging, I found that I need to explicitly set proxy= in config for OS provider. It would be nice if OS provider also check for *_PROXY variables and get proxy settings from there if found.

@prudhvigodithi
Copy link
Member

Hey @DenisBY the proxy feature was actually contributed in this PR #95, can you please check if you can enhance to use HTTPS_PROXY variable.
Adding @timwisbauer-contsec.
Thank you

@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Engineering Effectiveness Board Jul 18, 2024
@gnuletik gnuletik linked a pull request Oct 3, 2024 that will close this issue
Open
@gnuletik
Copy link

gnuletik commented Oct 3, 2024 •
edited
Loading

Should be fixed with #217

You can test it with my fork: https://registry.terraform.io/providers/gnuletik/opensearch/latest/docs
Latest version ship these two PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Engineering Effectiveness Board
Status: 📦 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support proxy env vars gnuletik/terraform-provider-opensearch
3 participants
@DenisBY @gnuletik @prudhvigodithi