Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failed network call gives no indication on the UI #35

Open
derek-ho opened this issue Jan 13, 2025 · 1 comment
Open

[BUG] Failed network call gives no indication on the UI #35

derek-ho opened this issue Jan 13, 2025 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@derek-ho
Copy link
Contributor

What is the bug?

When there is a network call that doesn't succeed, the response is a 200 looks like:

{
"ok": false,
"response": "no handler found for uri [/_insights/top_queries] and method [GET]"
}

And there is no indication on the UI that it failed. We should ideally not be giving 200 for things that fail, and some indication that the user needs to do something else

How can one reproduce the bug?

Steps to reproduce the behavior.

What is the expected behavior?

A clear and concise description of what you expected to happen.

What is your host/environment?

Operating system, version.

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

@derek-ho derek-ho added bug Something isn't working untriaged labels Jan 13, 2025
@andrross
Copy link
Member

andrross commented Feb 3, 2025

Catch All Triage - 1, 2, 3, 4, 5

@andrross andrross removed the untriaged label Feb 3, 2025
@ansjcy ansjcy added the good first issue Good for newcomers label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants