Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Avoid invalid retries on multiple replicas when querying #17361

Open
kkewwei opened this issue Feb 14, 2025 · 1 comment
Open
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc untriaged

Comments

@kkewwei
Copy link
Contributor

kkewwei commented Feb 14, 2025

Is your feature request related to a problem? Please describe

It is known that when a query fails in a shard, OpenSearch will select a new replica to retry. However, in certain cases, such as when encountering an IllegalArgumentException or TaskCancelledException, this retry is invalid.

In our product, some of the replicas have a count greater than 10. This leads to an excessive number of invalid retries, which not only increases the response time for users but also exerts unnecessary pressure on the cluster.

Describe the solution you'd like

When a query fails in a shard, and the exception is 4xx(IllegalArgumentException or TaskCancelledException), In such scenarios, we should fast fail the querying shard.

Related component

Search

Describe alternatives you've considered

No response

Additional context

No response

@kkewwei kkewwei added enhancement Enhancement or improvement to existing feature or request untriaged labels Feb 14, 2025
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Feb 14, 2025
@msfroh
Copy link
Collaborator

msfroh commented Feb 14, 2025

This is a great idea, @kkewwei !

Would you like me to assign it to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc untriaged
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants