Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default as BM25Similarity #17306

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Use default as BM25Similarity #17306

merged 1 commit into from
Feb 12, 2025

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Feb 9, 2025 •
edited
Loading

Description

Coming from #17241 (comment).

Related Issues

#17315

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Feb 9, 2025 •
edited
Loading

Adding @andrross @reta @msfroh @getsaurabh02.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

❌ Gradle check result for 55b453e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@prudhvigodithi prudhvigodithi force-pushed the 3.0.0-refactor branch 2 times, most recently from ccbd91b to 906ebb0 Compare February 9, 2025 17:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

❌ Gradle check result for 906ebb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@prudhvigodithi prudhvigodithi force-pushed the 3.0.0-refactor branch 2 times, most recently from 3c35909 to 203d685 Compare February 9, 2025 20:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

❌ Gradle check result for 203d685: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

❌ Gradle check result for a764974: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for c152c1f: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (77e4112) to head (d187ab6).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17306      +/-   ##
============================================
+ Coverage     72.40%   72.44%   +0.04%     
- Complexity    65554    65579      +25     
============================================
  Files          5292     5292              
  Lines        304493   304528      +35     
  Branches      44218    44226       +8     
============================================
+ Hits         220463   220617     +154     
+ Misses        65975    65841     -134     
- Partials      18055    18070      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi prudhvigodithi self-assigned this Feb 10, 2025
@prudhvigodithi prudhvigodithi mentioned this pull request Feb 11, 2025
Open
@prudhvigodithi
Use dafault BM25Similarity
d187ab6 
Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi prudhvigodithi marked this pull request as ready for review February 12, 2025 19:20
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d187ab6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for d187ab6: SUCCESS

@msfroh msfroh merged commit 5b2692f into opensearch-project:main Feb 12, 2025
52 of 54 checks passed
@prudhvigodithi prudhvigodithi linked an issue Feb 12, 2025 that may be closed by this pull request
Deprecate the LegacyBM25Similarity class and default to BM25Similarity #17315
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@cwperks cwperks cwperks left review comments

@msfroh msfroh msfroh approved these changes

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

@prudhvigodithi prudhvigodithi

Labels
None yet
Projects
Performance Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate the LegacyBM25Similarity class and default to BM25Similarity
4 participants
@prudhvigodithi @msfroh @reta @cwperks