Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[floorplan] invalid Link to leaflet #2739

Open
Larsen-Locke opened this issue Sep 1, 2024 · 3 comments
Open

[floorplan] invalid Link to leaflet #2739

Larsen-Locke opened this issue Sep 1, 2024 · 3 comments
Assignees
Labels
awaiting other PR Depends on another PR bug Something isn't working main ui Main UI

Comments

@Larsen-Locke
Copy link

The problem

On the bottom at the right of a floorplan there is a link to leaflet (the library for the map). This link is constructed wrong so you get not-found-error (/page/GR/https:/leafletjs.com)

Expected behavior

The link should probably be https://leafletjs.com

@Larsen-Locke Larsen-Locke added bug Something isn't working main ui Main UI labels Sep 1, 2024
@florian-h05
Copy link
Contributor

It seems that this link is part of Leaflet itself which means it’s not under our control to fix that.
But we are probably able to work around that by creating a redirect route inside the UI‘s router.

@florian-h05 florian-h05 self-assigned this Sep 12, 2024
@florian-h05
Copy link
Contributor

Okay I had a look at Leaflet itself and provided a PR to fix the link: Leaflet/Leaflet#9471
We have do wait for the fix getting merged and published in a new release, then we can upgrade Leaflet inside Main UI.

@Larsen-Locke
Copy link
Author

that's of course the more elegant solution

@florian-h05 florian-h05 added the awaiting other PR Depends on another PR label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting other PR Depends on another PR bug Something isn't working main ui Main UI
Projects
None yet
Development

No branches or pull requests

2 participants