You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If, however, isOverflowVisible is false - we encounter the original problem seen in #2938.
With the current implementation either value being set as the default will lead to some consumers encountering unintended behavior, so I'd like to propose we don't set a default and instead require consumers decide if they want overflow or not.
It's also possible there's a more robust solution I haven't thought of yet, and this may tie in to #2990 somehow.
The text was updated successfully, but these errors were encountered:
As of #2939,
isOverflowVisible
onModalDialog
defaults totrue
. This can lead to issues such as openedx/frontend-app-authoring#986.If, however,
isOverflowVisible
isfalse
- we encounter the original problem seen in #2938.With the current implementation either value being set as the default will lead to some consumers encountering unintended behavior, so I'd like to propose we don't set a default and instead require consumers decide if they want overflow or not.
It's also possible there's a more robust solution I haven't thought of yet, and this may tie in to #2990 somehow.
The text was updated successfully, but these errors were encountered: