-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
old and incomplete docs #774
Comments
Also, the URL in the repository about section return 404 |
Hi @CodeWithEmad - is this a ticket you're planning to tackle, and would like some advice? Or are you making a general ticket for someone else to work on? |
Hey @sarina. I am interested in contributing to this project, but I am not fully current with the recent Xblocks changes. It would be very beneficial to have a brief discussion with someone who is more closely involved with Xblock-related matters. |
@CodeWithEmad ah sorry that's not me 😅 I think some of it you could get started on like adding notes about the cookiecutter. This seems like a big ticket that would probably benefit from multiple PRs to make smaller changes to get feedback on. You could also try posting specific questions in the forum (maybe one at a time, to generate a more focused discussion) |
@CodeWithEmad You are right, the XBlock docs could really use some work, and your suggestions are good ones. +1 to Sarina's suggestion with breaking of proposal into smaller PRs, and the cookiecutter note is definitely a safe place to start. I'm happy to discuss the recent and upcoming XBlock changes so that you have all the information you need. Is there anything in particular you are wondering? |
Thanks for your suggestions. I'll create smaller PRs to update the docs but it might take a while. I'm also open to any suggestions. Well, I'm not the master of writing XBlocks, but for starters, one thing that I didn't find anywhere was the runtime services list and how the "needs" and "wants" decorators work and what the differences are. also, what about the React in xblocks? |
as the first attempt to improve the XBlock repo, I made this to clean up the readme and some smaller fixes: Also, the link inside the repos URL returns 404: https://edx.readthedocs.io/projects/xblock-tutorial/en/latest/overview/introduction.html |
Yes @sarina, I'm reading xblock docs from docs.openedx.org |
@CodeWithEmad thanks for catching that, I've fixed it. |
XBlocks are the heart of Open edX. Yet, somehow the documentation around it is not complete.
There are a lot of places that are referenced for future fixes or mentioned TODO. like:
https://docs.openedx.org/projects/xblock/en/latest/runtime.html#xblock.runtime.Runtime.service
I found this in Jira but it's quite old: https://openedx.atlassian.net/wiki/spaces/AC/pages/161400730/Open+edX+Runtime+XBlock+API
https://edx.readthedocs.io/projects/xblock/en/latest/xblock-tutorial/getting_started/
needs
andwants
decorators. (I know we can find the class method description https://edx.readthedocs.io/projects/xblock/en/latest/xblock.html#xblock.core.XBlock.needs but it's not clear for someone who's trying to develop an XBlock)PS. We can add a tutor approach for installing xblocks as well.
@openedx/axim-engineering
The text was updated successfully, but these errors were encountered: