-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare gRPC instrumentation donation for release #1261
Comments
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
I believe we should now have completed the following tasks:
By the way, I wanted to ask about |
Hi @michal-kazmierczak! Thanks for your gRPC example PR! I updated the issue to reflect the remaining TODOs.
You're right! Removing the conflicting doc is all that was needed. |
Thank you for the update @kaylareopelle. I've now posted another PR, I believe the last one before the release. It addresses the following points:
Once it gets merged, I'll prepare a PR with the release. |
That sounds great, @michal-kazmierczak! Forgive me if we've talked about this already, but would you be interested in becoming a code owner for the gRPC instrumentation going forward? By becoming a code owner, you would be added as a reviewer to any PR opened to update the The OpenTelemetry Ruby team needs help from end users and other experts in the community to maintain our instrumentation. Your work on the gRPC instrumentation is invaluable, and we'd love to continue working with you. |
Absolutely! I use gRPC in Ruby in my day-to-day work, and I’d be happy to help maintain and improve the instrumentation. Please feel free to add me as a code owner - I’d be glad to review PRs and assist with any gRPC-related issues. Looking forward to continuing to collaborate with the team. :) |
Overall, the goal is to update the donated gRPC gem to match the other contrib projects' structure and tooling. This will allow us to use our existing CI that runs tests and releases gems with this new instrumentation.
TODOs:
opentelemetry-instrumentation-all
gemRelates to the code merged in #1164
The text was updated successfully, but these errors were encountered: