You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
it'd be rather a change than a bug. in our app, we send otel metrics to datadog. and after a upgrade of "opentelemetry_phoenix" from 1.2 -> 2.0, we found that the span names from HTTP requests are changed from "{http.method} {http.route}" to only ""{http.method}. and this is caused by this commit, which introduced some change and the span name thus is different.
I also have a question. when I log out the span to stdout, I can see the span name is what we want. but if I export it to opentelemetry_exporter, the name would be only {http.method}. I guess there is some process in exporter to change the span name again...?
Describe the bug
it'd be rather a change than a bug. in our app, we send otel metrics to datadog. and after a upgrade of "opentelemetry_phoenix" from 1.2 -> 2.0, we found that the span names from HTTP requests are changed from "{http.method} {http.route}" to only ""{http.method}. and this is caused by this commit, which introduced some change and the span name thus is different.
from the spec, the span name should be
but the commit above stopped passing "http.route" to the attribute.
Expected behavior
we expect "http.route" is passed into attribute.
Additional context
without http.route
with http.route
I created a PR to fix this.
I also have a question. when I log out the span to stdout, I can see the span name is what we want. but if I export it to
opentelemetry_exporter
, the name would be only {http.method}. I guess there is some process in exporter to change the span name again...?The text was updated successfully, but these errors were encountered: