Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entityframeworkcore] Define stability requirements for ORM instrumentation #2223

Open
alanwest opened this issue Oct 17, 2024 · 0 comments
Open
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore question Further information is requested

Comments

@alanwest
Copy link
Member

alanwest commented Oct 17, 2024

Entity Framework is an ORM. As such, the instrumentation for it supports many database systems. The semantic conventions differ from system to system.

We must determine what unique requirements may exist in order to declare Entity Framework instrumentation stable.

This may not be an exhaustive list, but here's some things that differ depending on database system:

  1. See footnote for db.namespace: "Semantic conventions for individual database systems SHOULD document what db.namespace means in the context of that system."
  2. See footnote for network.peer.*: "Semantic conventions for individual database systems SHOULD document whether network.peer.* attributes are applicable."
@alanwest alanwest added the question Further information is requested label Oct 17, 2024
@github-actions github-actions bot added the comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore label Oct 17, 2024
@alanwest alanwest changed the title Define stability requirements for ORM instrumentation [entityframeworkcore] Define stability requirements for ORM instrumentation Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant