Resolves: Run model loading on separate thread #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- still needs tests to be updated
Comment on lines
+29
to
+31
| # def __init__( | ||
| # self, digest_model: Union[DigestOnnxModel, DigestReportModel], parent=None | ||
| # ): |
There was a problem hiding this comment.
Suggested change
| # def __init__( | |
| # self, digest_model: Union[DigestOnnxModel, DigestReportModel], parent=None | |
| # ): |
Delete comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5.
The issue is that some of the model loading is being done on the main GUI thread which can cause stalls (Window unresponsive warning for example) for larger models. This PR addresses that issue by ensuring all model loading is done on a separate thread. We also moved from the more manual thread lib QThread in favor of QThreadPool which maintains the lifetime of a thread automatically.