You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use Metro v.4.5.2 in my current project and tried the latest version v.5.* a couple days ago. There are some breaking changes in the new version and I have question about some of them, whether they made delibrately or not.
v4.5.2
Such as Dialog Title. The standard dialog title part of the Dialog component looks like this:
<div class="dialog-title">
My dialog title
</div>
By default the css properties for this div are set to display:block;
So far so good. I use an icon on the left side of the title text and a close button on the most right side.
For this reason I added the following classes to the dialog title:
v. 5.*
When I use my code with the new version 5.* the close button is shown on the left side.
The reason is simple:
The specifier class flex-justify-between is defined at line 2373 but dialog-title class is defined much later at line 32231.
So it overrides flex-justify-between.
Should specifier classes like .flex-justify-between not be defined after default classes for components like .dialog-title in order to avoid unnecessary breaking changes?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I use Metro v.4.5.2 in my current project and tried the latest version v.5.* a couple days ago. There are some breaking changes in the new version and I have question about some of them, whether they made delibrately or not.
v4.5.2
Such as Dialog Title. The standard dialog title part of the Dialog component looks like this:
By default the css properties for this div are set to display:block;
So far so good. I use an icon on the left side of the title text and a close button on the most right side.
For this reason I added the following classes to the dialog title:
v. 5.*
When I use my code with the new version 5.* the close button is shown on the left side.
The reason is simple:
The specifier class flex-justify-between is defined at line 2373 but dialog-title class is defined much later at line 32231.
So it overrides flex-justify-between.
Should specifier classes like .flex-justify-between not be defined after default classes for components like .dialog-title in order to avoid unnecessary breaking changes?
Beta Was this translation helpful? Give feedback.
All reactions