Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The medicine list is not filtering based on the search #10734

Open
nihal467 opened this issue Feb 20, 2025 · 5 comments
Open

The medicine list is not filtering based on the search #10734

nihal467 opened this issue Feb 20, 2025 · 5 comments
Labels
needs-triage question Further information is requested

Comments

@nihal467
Copy link
Member

Describe the bug

When searching for a medicine in the list view, the results are not sorted based on the search query, leading to incorrect or unfiltered results.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any encounter
  2. Search for a medicine
  3. See error

Expected behavior

The medicine list view should dynamically filter and display results based on the search query.

Screenshots

Image

@tellmeY18 tellmeY18 moved this to Triage in Care Feb 20, 2025
@tellmeY18 tellmeY18 added this to Care Feb 20, 2025
@AdityaJ2305
Copy link
Contributor

AdityaJ2305 commented Feb 20, 2025

@nihal467 again 😅 , solved in #10613
And not Just search few other bugs as well and this PR is reviewed just needs testing

@AdityaJ2305
Copy link
Contributor

Like toghle behaviour was not working and in administration where search is working if you inactive medicine it wouldn't show up ,solved that too

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 20, 2025
@nihal467
Copy link
Member Author

@AdityaJ2305 Avoid combining multiple unrelated issues in a single PR unless corresponding issues have been created for them. Additionally, ensure that the PR description clearly lists all the issues being addressed. I've noticed several PRs where unrelated issues are grouped together without proper issues or mention in the description.

Moving forward, please make sure that:

  1. Separate issues are opened for each problem being solved.
  2. PR descriptions explicitly state what changes have been made and which issues they address.

@nihal467 nihal467 removed question Further information is requested needs-triage labels Feb 20, 2025
@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 20, 2025
@AdityaJ2305
Copy link
Contributor

AdityaJ2305 commented Feb 20, 2025

@nihal467, I’ve reported the sub-issues in the main issue’s comments. Since they are related to the Medicine section, the PR title is “Fix Medicine-related bugs.” But yeah , I should update same in PR description that's my bad... Apologies

@AdityaJ2305
Copy link
Contributor

@nihal467 , Done updated the PR description and title of the issue for the same mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
Status: Triage
Development

No branches or pull requests

2 participants