Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in valueset page #10695

Open
3 tasks
nihal467 opened this issue Feb 19, 2025 · 15 comments · May be fixed by #10738
Open
3 tasks

Bugs in valueset page #10695

nihal467 opened this issue Feb 19, 2025 · 15 comments · May be fixed by #10738
Assignees

Comments

@nihal467
Copy link
Member

nihal467 commented Feb 19, 2025

Steps to Reproduce

  1. Login in as a super admin
  2. Open the admin dashboard
  3. Using the sidenav, access the valueset
  4. Try to replicate below mentioned bugs

Bugs in Values Set

Image

  • Valueset inactive status submissions are not working, since they are not sending proper values to the backend

Image

  • When we create a new value set, it's been forwarded to a 404-page post creation

Image

  • add pagination to the value set page
@tellmeY18 tellmeY18 added this to Care Feb 19, 2025
@tellmeY18 tellmeY18 moved this to Triage in Care Feb 19, 2025
@tellmeY18 tellmeY18 moved this from Triage to In Progress in Care Feb 19, 2025
@Sulochan-khadka
Copy link
Contributor

@nihal467 @amjithtitus09 may i take this issue?

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 19, 2025
@michael-020
Copy link

Hi @nihal467, I would like to work on this issue, can you please assign this issue to me?

@nihal467 nihal467 assigned gigincg and unassigned amjithtitus09 Feb 19, 2025
@nihal467
Copy link
Member Author

@gigincg can you look into it

@nihal467 nihal467 removed question Further information is requested needs-triage labels Feb 20, 2025
@nihal467
Copy link
Member Author

@Sulochan-khadka @michael-020 anyone still ready to take up the issue

@AdityaJ2305
Copy link
Contributor

@nihal467 , If they are not up , I would like to work on it

@Rishith25
Copy link
Contributor

@nihal467 I want to work on this as I have already working on some issues regarding this in my pr #10712

@Sulochan-khadka
Copy link
Contributor

yes @nihal467 , am already about to raise a PR

@Sulochan-khadka
Copy link
Contributor

Sulochan-khadka commented Feb 20, 2025

@AdityaJ2305 if you haven't progressed much, i would like to raise a PR

@AdityaJ2305
Copy link
Contributor

@AdityaJ2305 if you haven't progressed much, i would like to raise a PR

Hey @Sulochan-khadka , already started working on it 👍 Could you take up other one to avoid duplicate efforts

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 20, 2025
@Sulochan-khadka
Copy link
Contributor

@AdityaJ2305 if you haven't progressed much, i would like to raise a PR

Hey @Sulochan-khadka , already started working on it 👍 Could you take up other one to avoid duplicate efforts

sure

@nihal467 nihal467 removed question Further information is requested needs-triage labels Feb 20, 2025
@michael-020
Copy link

@Sulochan-khadka @michael-020 anyone still ready to take up the issue

Yes, I am please assign it to me, I would like to work on it

@AdityaJ2305
Copy link
Contributor

@Sulochan-khadka @michael-020 anyone still ready to take up the issue

Yes, I am please assign it to me, I would like to work on it

@michael-020 , I already started working on it and has made significant progress

@AdityaJ2305 AdityaJ2305 linked a pull request Feb 20, 2025 that will close this issue
11 tasks
@AdityaJ2305
Copy link
Contributor

@nihal467 , I have encountered a couple of bugs while solving above

  • Action column is hidden in case of long description (no scroll is there)
Image
  • Use Primary variant for Edit button. It is confused as text currently
  • on Editing a valueset and editing it again, it is not updating the form with last edit done

@Rishith25
Copy link
Contributor

Rishith25 commented Feb 21, 2025

Hey @AdityaJ2305
(1) will be solved in #10712

cc:@rithviknishad @Jacobjeevan

@AdityaJ2305
Copy link
Contributor

AdityaJ2305 commented Feb 21, 2025

Hey @Rishith25 , Let's don't do it the issue you are solving, that is related to questionnaire not valueset and additional it is about css change not any bug solving. Let not combine unrelated issues/tasks

Image

Cc: @rithviknishad @Jacobjeevan

Edit: I just checked out, you haven't made any changes regarding (1) yet, so we saved up on duplicate efforts situation 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

7 participants