Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindDocuments Registry Stored Query (ITI-18) is missing the "author" query parameter #10

Open
nick-mpampamis opened this issue May 16, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@nick-mpampamis
Copy link

According to the IHE ITI TF Vol2 for the Registry Stored Query (ITI-18), the FindDocuments stored query shall support the optional "author" query parameter.

Additionally, the note on this query parameter says:

The value for this parameter is a pattern compatible with the SQL keyword LIKE which allows the use of the following wildcard characters: % to match any (or no) characters and _ to match a single character. The match shall be applied to the text contained in the Value elements of the authorPerson Slot on the author Classification (value strings of the authorPerson sub-attribute)

@Thopap
Copy link
Member

Thopap commented May 16, 2024

Hello @nick-mpampamis,

definitely valid observation. This is currently one of the limitations.

The background here:
Currently author is implemented with a fhir contained resource. With this approach, most fhir server's do not support a search on contained resources.

The simple option might be a in-memory search, so the xds-registry-to-fhir service will fetch more fhir resources that necessary.

Does this sound reasonable for you? Do you any further proposoals / idea's here.

@nick-mpampamis
Copy link
Author

Hello @Thopap!

I think we should be able to search contained resources in FHIR, according to the Search documentation.

I tested it with the Firely and Hapi FHIR server and they both support it.

curl 'https://server.fire.ly/DocumentReference?author%3APractitionerRole.practitioner.name:exact=Norbi'

Unfortunately FHIR :exact and :contains modifiers do not cover all the needs of the XDS query param (e.g. SQL LIKE).

Your solution for in-memory filtering by author after fetching the results from FHIR is simple and will work and seems to be the only solution for now.

@Thopap Thopap added the enhancement New feature or request label May 17, 2024
@Thopap
Copy link
Member

Thopap commented May 17, 2024

Good to know that the firely testserver can be used.

I will play around a bit and see what can be done provided here.

@Thopap Thopap self-assigned this May 17, 2024
Thopap added a commit that referenced this issue May 19, 2024
@Thopap
Copy link
Member

Thopap commented May 19, 2024

AuthorPerson evaluation as in-memory filtering implemented (will affect FindDocuments, FindSubmissionSet and FindDocumentsByReferenceId). XDSTools now also mark these tests as green.

Before closing this issue, i will check if fhir criteria can be added on top to reduce the number of documents that are evaluated in-memory.

Demo deployment on http://xds.thopap.de:8081/ was updated.

Thopap added a commit that referenced this issue May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants