Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields can take empty/blank string without warnings #6017

Open
nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Open

Fields can take empty/blank string without warnings #6017

nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Assignees
@joshualiangxy @zhxchd @Lingy12 @Nauw1010 @jazerler
Labels
response.Rejected severity.Medium status.Done team.4 tutorial.CS2103T-W17 type.FunctionalityBug

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 13, 2020 •
edited by zhxchd
Loading

"findc n/" or "findc n/(empty space)" can both run without warnings. And the empty spaces seem not counted into name matching as it shows all persons.

image.png

[original: nus-cs2103-AY2021S1/pe-interim#6010]
@zhxchd
Copy link
Contributor

zhxchd commented Nov 14, 2020 •
edited by joshualiangxy
Loading

Team's Response

If no name is provided, it is expected that all names matches.

This is similar to using an empty search term in the CATCHER interface.

Duplicate status (if any):

--

@zhxchd zhxchd added duplicate This issue or pull request already exists status.Done labels Nov 14, 2020
@joshualiangxy joshualiangxy removed the duplicate This issue or pull request already exists label Nov 14, 2020
@joshualiangxy joshualiangxy mentioned this issue Nov 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshualiangxy joshualiangxy

@zhxchd zhxchd

@Lingy12 Lingy12

@Nauw1010 Nauw1010

@jazerler jazerler

Labels
response.Rejected severity.Medium status.Done team.4 tutorial.CS2103T-W17 type.FunctionalityBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@joshualiangxy @zhxchd @Lingy12 @nus-pe-bot @Nauw1010 @jazerler