Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernels page reloads unnecessarily when switching language #105

Open
lgeiger opened this issue Nov 10, 2018 · 4 comments
Open

Kernels page reloads unnecessarily when switching language #105

lgeiger opened this issue Nov 10, 2018 · 4 comments
Labels

Comments

@lgeiger
Copy link
Member

lgeiger commented Nov 10, 2018

kernels

@rgbkrk
Copy link
Member

rgbkrk commented Nov 10, 2018

We should move much of the layout stuff to _app.js which we haven't taken advantage of since it originally launched.

@lgeiger
Copy link
Member Author

lgeiger commented Nov 10, 2018

I think this is mainly a problem of our custom server and the next.js router not playing well together.

I wonder if we should just rip out the custom express server and use queries for persisting the language selection. This would mean changing the URL from nteract.io/kernels/python to something like nteract.io/kernels?language=python.

@rgbkrk
Copy link
Member

rgbkrk commented Nov 11, 2018

I think now that we don't do the redirect we can switch to a plain next setup.

@rgbkrk
Copy link
Member

rgbkrk commented Nov 11, 2018

Oh also we can do the query thing and keep those paths with the custom server. It's what we do for commuter.

@willingc willingc added the bug label Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants