Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn/error on unecessary config items in publishConfig #932

Open
Tracked by #491 ...
wraithgar opened this issue Jan 21, 2025 · 3 comments
Open
Tracked by #491 ...

Warn/error on unecessary config items in publishConfig #932

wraithgar opened this issue Jan 21, 2025 · 3 comments
Assignees

Comments

@wraithgar
Copy link
Member

wraithgar commented Jan 21, 2025

Part of the config validation warning effort #934

@ljharb
Copy link

ljharb commented Jan 21, 2025

This will be pretty disruptive fwiw - I have ignore in my publishConfig in all my projects, because i use it with https://npmjs.com/npmignore to autogenerate an .npmignore file.

@wraithgar
Copy link
Member Author

Well that's the danger you run when you co-opt a config meant for npm itself.

@ljharb
Copy link

ljharb commented Jan 21, 2025

That's certainly a position to take, but since npm's never claimed that section as "for itself" before, I'm not sure it's a valuable tradeoff to assert that claim now.

Warning on something that someone might think npm would use, but it doesn't, makes perfect sense - but npm's never warned on any unknown properties before either afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants