Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue language server support #9

Open
Steve-Mcl opened this issue Feb 12, 2024 · 6 comments
Open

Add vue language server support #9

Steve-Mcl opened this issue Feb 12, 2024 · 6 comments

Comments

@Steve-Mcl
Copy link
Collaborator

Add support for vue syntax checking - goes hand in hand with Dashboard 2.0 which is vue based.

See here for details: https://discourse.nodered.org/t/weather-card-strugguling-with-methods/85434/6?u=steve-mcl

@dceejay
Copy link
Member

dceejay commented Feb 12, 2024

Does this volar library mentioned (13MB) get installed on every load ? or only if you edit dashboard ?

@Steve-Mcl
Copy link
Collaborator Author

Steve-Mcl commented Feb 12, 2024

It'll hopefully be ~4mb once compiled/minified (the other existing web workers for Monaco are) but if done right, should only requested when the editor calls for that language. It'll be held in memory while NR editor is open & should be cached for future reloads.

@dceejay
Copy link
Member

dceejay commented Feb 12, 2024

can it be added as (a plugin?) part of the dashboard2 install ?

@Steve-Mcl
Copy link
Collaborator Author

Hmmmm. Maaaaybe. I mean anything is possible. Would need to be coordinated between the 2.

Will give it some thought.

@dceejay
Copy link
Member

dceejay commented Feb 12, 2024

IE - could either onpaletteadd cause it to be loaded - or maybe an npm post install script to move worker into correct place to be picked up automatically - then again if it really is only 4MB - what's another bit of bloat between friends...
(Does seem like a useful thing to help Dashboard2)

@joepavitt
Copy link

joepavitt commented Apr 4, 2024

(Does seem like a useful thing to help Dashboard2)

Can vouch for the value on Dashboard 2.0 here - we're getting people ask for it daily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants