Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROUPR problems with photon production matrices #258

Open
wempleca opened this issue Sep 9, 2022 · 6 comments
Open

GROUPR problems with photon production matrices #258

wempleca opened this issue Sep 9, 2022 · 6 comments

Comments

@wempleca
Copy link

wempleca commented Sep 9, 2022

We have encountered two problems with the GROUPR module related to calculation of photon production matrices. The first (easily resolved) involved a search for the group containing the lowest energy photon in subroutine getff (beginning at line 7139), where the search may find a group number larger than the number of photon energy groups and produce an out-of-bound array reference later in the subroutine.

The second was more profound and connected to the first. In subroutine getff, a value is assigned to the local variable econ, which is used in the search loop mentioned above, that is derived from an array eccn returned by subroutine getgyl. Subroutine getgyl assumes that the File 12 data in the evaluated data file does not have a final entry that contains incident neutron energy-dependent yields, and that the lowest energy photon produced by the neutron interaction may be obtained simply by grabbing the value EGk from the first entry on the TAB1 record. If the last entry does contain incident neutron energy-dependent data (LP=2), this returned value is 0.0 (which produces the first problem, as described above). Unfortunately, preventing the out-of-bounds array reference results in no photon production being produced for the offending neutron reaction. This is particularly problematic for nuclides such as N-14 in E7R0/E7R1/E8R0, where the neutron capture reaction (MT=102) produces no photons (the problem is generic for nuclides with an LP=2 section for the highest neutron energy section of File 12). This is obviously quite disruptive to our efforts to produce coupled multi-group neutron-gamma XS libraries for our transport codes.

I am attaching our input file for N-14. Feel free to contact me if additional information is required.

N014.inp.txt

@nathangibson14
Copy link
Contributor

Thanks, @wempleca. I'll start looking into this. Are you getting segfaults or other errors on the first problem, or does it appear more subtlety?

I'll also look at the photon production matrices I have processed myself. I'm wondering if you've uncovered something that we all should be concerned about.

--Nathan

@wempleca
Copy link
Author

wempleca commented Sep 12, 2022 via email

@jchsublet
Copy link

jchsublet commented Sep 13, 2022

@nathangibson14 @wempleca

This caught my attention as the issue(s) seem to be subtle, there are not that many N014 files around, secondaries other than neutron are gaining some importance

a) the issue is not picked up, flagged nor noticed by acer checks; all seems fine when the gammas are transported, read through acer or not read by heatr

https://t2.lanl.gov/nis/data/endf/ebalVII.1/summary.html
https://t2.lanl.gov/nis/data/endf/ebalVII.1/n/14chk.pdf
N014chk.pdf on ENDF/B-VIII.0 page 43 to 46

b) the issue has also been noticed by heatr (card 2 gamma local=1) and when ask to do more like in the slightly modified input deck, looking at tape31 through viewr, no gamma heating below 20 MeV

N014mod.txt
tape31.pdf

This also resonate with some of the findings made in a recent TM on secondaries https://conferences.iaea.org/event/260/

@wempleca
Copy link
Author

Additional information to consider - the following isotopes exhibit similar behavior for MT=102 photon production from E8R0:

N-14
F-19
Al-27
Cl-35
Cl-37
Cr-50
Cr-52
Cr-53
Cr-54
Xe-123
Ta-180
Ta-181
Re-185
Re-187

Most of these give partial production from low-energy neutron capture, but nothing for the higher energy neutron capture. This was not the case for NJOY2012; I am attaching our input and outputs for Cr-50 from both NJOY2012 and NJOY2016 for reference.
Cr050.inp.txt
Cr50out-2012.txt
Cr50out-2016.txt

@wempleca
Copy link
Author

Attached are input and output files from NJOY-2016 for U235. Note the near total lack of gamma production.

U235.njoy.inp.txt
U235.njoy.out.txt

@Ambr0K
Copy link

Ambr0K commented Feb 24, 2024

We've also encountered on something similar with FENDL3.2b processing, using custom group structure. For our needs, we seem to be getting good results for gamma transport part using igg=10 -> vitamin-j 42-group structure up to 50 MeV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants