Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent usage of NITRO_SHUTDOWN_TIMEOUT #3087

Open
kaaax0815 opened this issue Feb 12, 2025 · 0 comments
Open

inconsistent usage of NITRO_SHUTDOWN_TIMEOUT #3087

kaaax0815 opened this issue Feb 12, 2025 · 0 comments

Comments

@kaaax0815
Copy link

kaaax0815 commented Feb 12, 2025

Environment

not relevant

Reproduction

not relevant

Describe the bug

Here:

Number.parseInt(process.env.NITRO_SHUTDOWN_TIMEOUT || "", 10) || 3;

The default for NITRO_SHUTDOWN_TIMEOUT is 3. And the Unit is seconds.

Here:

Number.parseInt(process.env.NITRO_SHUTDOWN_TIMEOUT || "", 10) || 30_000,

The default for NITRO_SHUTDOWN_TIMEOUT is 30_000. And the Unit is milliseconds.

The docs:

- `NITRO_SHUTDOWN_TIMEOUT` - Sets the amount of time (in milliseconds) before a forced shutdown occurs. Defaults to `'30000'` milliseconds.

Specify a default of 30000 and a unit of milliseconds.

The Problem wouldn't be that big if the default between dev and prod would be different. but the unit is different. therefore using NITRO_SHUTDOWN_TIMEOUT is impossible

This issue persists both in v2 and v3

Additional context

No response

Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant